Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Introducing metrics-server#51792

Merged
k8s-github-robot merged 2 commits into
kubernetes:masterfrom
piosz:metrics-server
Sep 4, 2017
Merged

Introducing metrics-server#51792
k8s-github-robot merged 2 commits into
kubernetes:masterfrom
piosz:metrics-server

Conversation

@piosz
Copy link
Copy Markdown
Member

@piosz piosz commented Sep 1, 2017

ref kubernetes/enhancements#271

There is still some work blocked on problems with repo synchronization:

Introduced Metrics Server

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 1, 2017
@k8s-github-robot k8s-github-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Sep 1, 2017
@luxas luxas added this to the v1.8 milestone Sep 1, 2017
@piosz
Copy link
Copy Markdown
Member Author

piosz commented Sep 1, 2017

/test pull-kubernetes-unit

@piosz
Copy link
Copy Markdown
Member Author

piosz commented Sep 1, 2017

/test pull-kubernetes-e2e-gce-etcd3

@piosz
Copy link
Copy Markdown
Member Author

piosz commented Sep 1, 2017

/test pull-kubernetes-kubemark-e2e-gce

@piosz
Copy link
Copy Markdown
Member Author

piosz commented Sep 1, 2017

/test pull-kubernetes-federation-e2e-gce

@piosz
Copy link
Copy Markdown
Member Author

piosz commented Sep 1, 2017

/test pull-kubernetes-kubemark-e2e-gce

@mikedanese
Copy link
Copy Markdown
Member

mikedanese commented Sep 1, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 1, 2017
mikedanese
mikedanese reviewed Sep 1, 2017
View reviewed changes
Comment thread cluster/addons/metrics-server/auth-delegator.yaml Outdated
Copy link
Copy Markdown
Member

@mikedanese mikedanese Sep 1, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks find but cc @deads2k

Copy link
Copy Markdown
Member Author

@piosz piosz Sep 1, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was reviewed in kubernetes-sigs/metrics-server#4

Copy link
Copy Markdown
Contributor

@deads2k deads2k Sep 1, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks find but cc @deads2k

That's the role name. It allows the caller to hit tokenaccessreviews and subjectaccessreviews.

@mikedanese
Copy link
Copy Markdown
Member

mikedanese commented Sep 1, 2017

/approve

@piosz piosz removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 1, 2017
@piosz piosz unassigned luxas Sep 1, 2017
@piosz
Copy link
Copy Markdown
Member Author

piosz commented Sep 1, 2017

removed lgtm label to let @DirectXMan12 to take a look

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 1, 2017
@DirectXMan12
Copy link
Copy Markdown
Contributor

DirectXMan12 commented Sep 1, 2017

looks fine at a glance. Will take a closer look a bit later if need be. metrics-server needs to be updated to use metrics.k8s.io/v1beta1, otherwise it won't work once the resource metrics API update merges, though.

@piosz
Copy link
Copy Markdown
Member Author

piosz commented Sep 1, 2017

@DirectXMan12 will update this once #51653 is merged. It's currently not used by HPA so it's safe to merge it.

@calebamiles calebamiles modified the milestone: v1.8 Sep 2, 2017
DirectXMan12
DirectXMan12 suggested changes Sep 3, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@DirectXMan12 DirectXMan12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Squash RBAC fix, plus comments inline

Comment thread cluster/addons/metrics-server/metrics-server-deployment.yaml Outdated
Copy link
Copy Markdown
Contributor

@DirectXMan12 DirectXMan12 Sep 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please list ports here

Copy link
Copy Markdown
Member Author

@piosz piosz Sep 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Comment thread cluster/gce/config-default.sh Outdated
Copy link
Copy Markdown
Contributor

@DirectXMan12 DirectXMan12 Sep 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is going to be enabled by default, we should be using it for something, and should not deploy (or at least warn about) Heapster. Turn it on in a separate PR once we're ready to make the HPA use it by default.

Copy link
Copy Markdown
Member Author

@piosz piosz Sep 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to switch HPA in 1.8 to use metrics server.

Heapster is used by dashboard. Also we should perform a graceful switch and have both metrics-server and Heapster enabled in one release (1.8).

Copy link
Copy Markdown
Contributor

@DirectXMan12 DirectXMan12 Sep 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, ack.

@piosz
Copy link
Copy Markdown
Member Author

piosz commented Sep 3, 2017

@DirectXMan12 comments addressed. PTAL

@DirectXMan12
Copy link
Copy Markdown
Contributor

DirectXMan12 commented Sep 3, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 3, 2017
@k8s-github-robot
Copy link
Copy Markdown

k8s-github-robot commented Sep 3, 2017

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DirectXMan12, mikedanese, piosz

Associated issue: 271

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@fejta-bot
Copy link
Copy Markdown

fejta-bot commented Sep 4, 2017

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

1 similar comment
@fejta-bot
Copy link
Copy Markdown

fejta-bot commented Sep 4, 2017

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

@piosz
Copy link
Copy Markdown
Member Author

piosz commented Sep 4, 2017

/test pull-kubernetes-e2e-kops-aws

1 similar comment
@piosz
Copy link
Copy Markdown
Member Author

piosz commented Sep 4, 2017

/test pull-kubernetes-e2e-kops-aws

@piosz piosz added this to the v1.8 milestone Sep 4, 2017
@k8s-github-robot
Copy link
Copy Markdown

k8s-github-robot commented Sep 4, 2017

/test all [submit-queue is verifying that this PR is safe to merge]

@piosz
Copy link
Copy Markdown
Member Author

piosz commented Sep 4, 2017

/test pull-kubernetes-e2e-gce-etcd3

@piosz
Copy link
Copy Markdown
Member Author

piosz commented Sep 4, 2017

/test pull-kubernetes-e2e-kops-aws

@k8s-github-robot
Copy link
Copy Markdown

k8s-github-robot commented Sep 4, 2017

Automatic merge from submit-queue (batch tested with PRs 49727, 51792)

@k8s-github-robot k8s-github-robot merged commit ffed1d3 into kubernetes:master Sep 4, 2017
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Sep 4, 2017 •
edited
Loading

@piosz: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-kops-aws f939111 link /test pull-kubernetes-e2e-kops-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@piosz piosz deleted the metrics-server branch September 4, 2017 11:05
@jdumars
Copy link
Copy Markdown
Contributor

jdumars commented Sep 6, 2017

@piosz could you please add a SIG label? Thanks!

@luxas luxas added the sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. label Sep 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deads2k deads2k deads2k left review comments

+2 more reviewers

@mikedanese mikedanese mikedanese left review comments

@DirectXMan12 DirectXMan12 DirectXMan12 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@DirectXMan12 DirectXMan12

@mikedanese mikedanese

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

v1.8

Development

Successfully merging this pull request may close these issues.

10 participants

@piosz @mikedanese @DirectXMan12 @k8s-github-robot @fejta-bot @k8s-ci-robot @jdumars @deads2k @calebamiles @luxas