Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Switch default audit policy to beta and omit RequestReceived stage#52343

Merged
k8s-github-robot merged 1 commit into
kubernetes:masterfrom
crassirostris:audit-policy-switch-to-beta
Sep 13, 2017
Merged

Switch default audit policy to beta and omit RequestReceived stage#52343
k8s-github-robot merged 1 commit into
kubernetes:masterfrom
crassirostris:audit-policy-switch-to-beta

Conversation

@crassirostris
Copy link
Copy Markdown

@crassirostris crassirostris commented Sep 12, 2017

Related to #52265

By default, clusters on GCE no longer sends RequestReceived audit event, if advanced audit is configured.

@crassirostris crassirostris added area/platform/gce sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. labels Sep 12, 2017
@crassirostris crassirostris added this to the v1.8 milestone Sep 12, 2017
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 12, 2017
@crassirostris crassirostris force-pushed the audit-policy-switch-to-beta branch from be30bc8 to 0933f5c Compare September 12, 2017 14:36
@k8s-github-robot k8s-github-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Sep 12, 2017
@tallclair
Copy link
Copy Markdown
Member

tallclair commented Sep 12, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 12, 2017
@roberthbailey
Copy link
Copy Markdown
Contributor

roberthbailey commented Sep 12, 2017

/approve

@k8s-github-robot
Copy link
Copy Markdown

k8s-github-robot commented Sep 12, 2017

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crassirostris, roberthbailey, tallclair

Associated issue: 52265

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 12, 2017
@fejta-bot
Copy link
Copy Markdown

fejta-bot commented Sep 13, 2017

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to @fejta).

Review the full test history for this PR.

@k8s-github-robot
Copy link
Copy Markdown

k8s-github-robot commented Sep 13, 2017

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Sep 13, 2017 •
edited
Loading

@crassirostris: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-unit 0933f5c link /test pull-kubernetes-unit
pull-kubernetes-federation-e2e-gce 0933f5c link /test pull-kubernetes-federation-e2e-gce

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot
Copy link
Copy Markdown

k8s-github-robot commented Sep 13, 2017

Automatic merge from submit-queue (batch tested with PRs 52339, 52343, 52125, 52360, 52301)

@k8s-github-robot k8s-github-robot merged commit e81aeb5 into kubernetes:master Sep 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@piosz piosz Awaiting requested review from piosz

@tallclair tallclair Awaiting requested review from tallclair

Assignees

@mikedanese mikedanese

@tallclair tallclair

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/platform/gce cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

v1.8

Development

Successfully merging this pull request may close these issues.

7 participants

@crassirostris @tallclair @roberthbailey @k8s-github-robot @fejta-bot @k8s-ci-robot @mikedanese