Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update generated copyrights so people stop getting huge diffs #57729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Update generated copyrights so people stop getting huge diffs #57729

wants to merge 1 commit into from

Conversation

mtaufen
Copy link
Contributor

@mtaufen mtaufen commented Jan 2, 2018

Fixes #57728, sort of

The generator really wants to do this, so I say we let it do it as a hotfix to stop people getting large diffs, and then figure out a way to handle this more intelligently for the 2018->2019 transition.

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 2, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mtaufen
We suggest the following additional approver: lavalamp

Assign the PR to them by writing /assign @lavalamp in a comment when ready.

Associated issue: #57728

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@mtaufen mtaufen mentioned this pull request Jan 2, 2018
Closed
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 2, 2018 •
edited
Loading

@mtaufen: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-bazel-test 92f6bd1 link /test pull-kubernetes-bazel-test
pull-kubernetes-verify 92f6bd1 link /test pull-kubernetes-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@cblecker
Copy link
Member

cblecker commented Jan 2, 2018

Thanks for this @mtaufen.. was just about to do the same.
We also need to update this regex to support 2018: 9853420

And it also looks like there some other generated files.. a full make update should catch them all.

ref: #39342
cc: @ixdy @thockin @smarterclayton @sttts

To quote @ixdy:

I'm hoping that maybe the generated code situation will be a in a better place by 2018...

Nope 🙃.

/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Jan 2, 2018
@sttts
Copy link
Contributor

sttts commented Jan 2, 2018

And it also looks like there some other generated files.. a full make update should catch them all.

Waiting for that one. Otherwise lgtm.

@cblecker cblecker mentioned this pull request Jan 2, 2018
Merged
@cblecker
Copy link
Member

cblecker commented Jan 2, 2018

As this is blocking all PRs and CI, I opened #57735. make update got most of them, but there were two code generation scripts it missed. I added those into the right places for next time.

@mtaufen
Copy link
Contributor Author

mtaufen commented Jan 2, 2018

@cblecker thanks! Since it looks like you've got it covered, I'm going to close this PR.

@mtaufen mtaufen closed this Jan 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lavalamp lavalamp

@saad-ali saad-ali

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Code generator wants to replace 2017 with 2018 in all generated license statements
6 participants
@mtaufen @k8s-ci-robot @cblecker @sttts @lavalamp @saad-ali