Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

wangzhen127
Copy link
Member

@wangzhen127 wangzhen127 commented Nov 28, 2018

What type of PR is this?
/kind feature

What this PR does / why we need it:
Use Node-Problem-Detector v0.6.0 on GCI. NPD v0.6.0 added a few more plugins to detect more node problems. It also fixed a custom plugin bug. This is part of #71526.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
This PR also updates the kubeconfig needed by NPD and fixes kubernetes/node-problem-detector#227

Special notes for your reviewer:
Currently v0.5.0 is being used.

Does this PR introduce a user-facing change?:

On GCI, NPD starts to monitor kubelet, docker, containerd crashlooping, read-only filesystem and corrupt docker overlay2 issues.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 28, 2018
@wangzhen127
Copy link
Member Author

/sig node
/assign @Random-Liu

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 28, 2018
@k8s-ci-robot k8s-ci-robot requested review from bowei and vishh November 28, 2018 19:54
@k8s-ci-robot k8s-ci-robot added the sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. label Nov 28, 2018
@wangzhen127
Copy link
Member Author

/sig gcp

@wangzhen127 wangzhen127 changed the title Use Node-Problem-Detector v0.6.0 Use Node-Problem-Detector v0.6.0 on GCI Nov 28, 2018
@wangzhen127
Copy link
Member Author

Just verified node-problem-detector.log in pull-kubernetes-e2e-gke and pull-kubernetes-e2e-gce and NPD is working correctly.

/assign @yguo0905

@yguo0905
Copy link
Contributor

yguo0905 commented Dec 3, 2018

/lgtm
/hold
hold if you also want others to lgtm.

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Dec 3, 2018
@yguo0905
Copy link
Contributor

yguo0905 commented Dec 3, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wangzhen127, yguo0905

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 3, 2018
@Random-Liu Random-Liu added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Dec 3, 2018
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Dec 3, 2018
@Random-Liu
Copy link
Member

/lgtm

@wangzhen127
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 3, 2018
@k8s-ci-robot k8s-ci-robot merged commit 4206790 into kubernetes:master Dec 3, 2018
@wangzhen127 wangzhen127 deleted the npd branch December 3, 2018 23:57
k8s-ci-robot added a commit that referenced this pull request Dec 8, 2018
…71522-upstream-release-1.12

Automated cherry pick of #71522: Use Node-Problem-Detector v0.6.0
k8s-ci-robot added a commit that referenced this pull request Dec 10, 2018
…71522-upstream-release-1.10

Automated cherry pick of #71522: Use Node-Problem-Detector v0.6.0
k8s-ci-robot added a commit that referenced this pull request Dec 10, 2018
…71522-upstream-release-1.13

Automated cherry pick of #71522: Use Node-Problem-Detector v0.6.0
k8s-ci-robot added a commit that referenced this pull request Dec 11, 2018
…71522-upstream-release-1.11

Automated cherry pick of #71522: Use Node-Problem-Detector v0.6.0
@wangzhen127
Copy link
Member Author

Cherry picks are all merged. NPD v0.6.0 will be available in the following releases:
v1.10.12, v1.11.6, v1.12.4, v1.13.1, v1.14+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NPD HEAD not working on GKE
4 participants