Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update examples/spark for v1beta3 #7230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2015
Merged

Update examples/spark for v1beta3 #7230

merged 1 commit into from
Apr 24, 2015

Conversation

bcbroussard
Copy link
Contributor

Small part of #6584.

@nikhiljindal
Copy link
Contributor

Thanks a lot for the PR @bcbroussard
v1beta3 is now the default API version. We can just replace the v1beta1 json files by beta3 ones.
Instead of adding a v1beta3 folder, can you just replace the top level beta1 files?

Thanks!

nikhiljindal
nikhiljindal reviewed Apr 23, 2015
View reviewed changes
examples/spark/v1beta3/spark-master-service.json Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can just delete this field

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, missed that one. Updated.

@bcbroussard
Copy link
Contributor Author

@nikhiljindal - Sure thing, I was wondering about that, but decided to play it safe and follow the pattern Tim and others were using. Making the updates on my other PR's too

@bcbroussard
Copy link
Contributor Author

@nikhiljindal - commits squashed, should be ready to go

@nikhiljindal
Copy link
Contributor

LGTM, Thanks!

@nikhiljindal nikhiljindal added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 24, 2015
nikhiljindal added a commit that referenced this pull request Apr 24, 2015
@nikhiljindal
Merge pull request #7230 from bcbroussard/spark-example
113efcd 
Update examples/spark for v1beta3
@nikhiljindal nikhiljindal merged commit 113efcd into kubernetes:master Apr 24, 2015
@bcbroussard bcbroussard deleted the spark-example branch May 28, 2015 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nikhiljindal nikhiljindal

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bcbroussard @nikhiljindal @googlebot