Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update examples/storm for v1beta3 #7231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2015
Merged

Update examples/storm for v1beta3 #7231

merged 1 commit into from
Apr 24, 2015

Conversation

bcbroussard
Copy link
Contributor

Small part of #6584.

@nikhiljindal nikhiljindal self-assigned this Apr 23, 2015
@bcbroussard bcbroussard force-pushed the storm-example branch 2 times, most recently from 8f7a8e7 to e6c362e Compare April 24, 2015 01:23
nikhiljindal
nikhiljindal reviewed Apr 24, 2015
View reviewed changes
examples/storm/README.md Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes in this file are not required anymore.
Please revert.

@nikhiljindal
Copy link
Contributor

LGTM, modulo one comment

@bcbroussard
Copy link
Contributor Author

@nikhiljindal fixed

@nikhiljindal
Copy link
Contributor

Thanks! Lgtm.

@nikhiljindal nikhiljindal added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 24, 2015
nikhiljindal added a commit that referenced this pull request Apr 24, 2015
@nikhiljindal
Merge pull request #7231 from bcbroussard/storm-example
dca49ba 
Update examples/storm for v1beta3
@nikhiljindal nikhiljindal merged commit dca49ba into kubernetes:master Apr 24, 2015
@bcbroussard bcbroussard deleted the storm-example branch May 28, 2015 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nikhiljindal nikhiljindal

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bcbroussard @nikhiljindal @googlebot