discovery: speedup kubectl restmapper cache misses by a two-digit factor #73345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sttts
commented
Jan 26, 2019
| @@ -145,27 +145,34 @@ func NewDiscoveryRESTMapper(groupResources []*APIGroupResources) meta.RESTMapper | |||
| // GetAPIGroupResources uses the provided discovery client to gather | |||
| // discovery information and populate a slice of APIGroupResources. | |||
| func GetAPIGroupResources(cl discovery.DiscoveryInterface) ([]*APIGroupResources, error) { | |||
| // TODO: we don't want this ServerGroups call. It is only there to get the metav1.APIGroup struct used below. | |||
|
/hold until https://github.com/kubernetes/kubernetes/pull/73345/files#r251196320 is fixed. |
|
/cc |
|
/assign @caesarxuchao @logicalhan |
a913a2c to
5f88a2c
Compare
|
/hold cancel |
d340629 to
eaaca48
Compare
liggitt
reviewed
Feb 5, 2019
liggitt
reviewed
Feb 5, 2019
|
the ServerGroupsAndResources change looks good (modulo interface documentation). The GetAPIGroupResources change needs thought to either behave the same in partial discovery cases, or to update callers to handle partial discovery results correctly. |
eaaca48 to
4a32ce1
Compare
soltysh
approved these changes
Feb 12, 2019
4a32ce1 to
ad4f045
Compare
ad4f045 to
0fcf5ba
Compare
|
New changes are detected. LGTM label has been removed. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, soltysh, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
0fcf5ba to
2cdddd8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The restmapper code did not call the optimized, parallelized API group resources discovery func, but did its own serial requests, one per API group version. Each took some hundred milliseconds, adding up to >10 sec for cluster with 40ish many API group versions.
Note: the tests in the first commit are also green before the second and third commits are applied.