Thanks to visit codestin.com
Credit goes to github.com

Skip to content

test case for shared volumes between the containers in pod #73523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 12, 2019
Merged

test case for shared volumes between the containers in pod #73523

merged 1 commit into from
Feb 12, 2019

Conversation

pontiyaraja
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug

/kind cleanup

/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it: covered test case for shared volumes between containers in pod

Which issue(s) this PR fixes:#73429

Fixes #73429

Special notes for your reviewer: covered test case for the emptDir shared volume between the containers in pod.

Does this PR introduce a user-facing change?:

NONE

/area conformance
/assign @msau42

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. area/conformance Issues or PRs related to kubernetes conformance tests labels Jan 30, 2019
@k8s-ci-robot k8s-ci-robot added needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 30, 2019
@pontiyaraja
Copy link
Contributor Author

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 30, 2019
@pontiyaraja pontiyaraja changed the title Test case for shared volumes between the containers in pod test case for shared volumes between the containers in pod Jan 30, 2019
@pontiyaraja
Copy link
Contributor Author

/test pull-kubernetes-e2e-kops-aws
/test pull-kubernetes-e2e-gce

1 similar comment
@pontiyaraja
Copy link
Contributor Author

/test pull-kubernetes-e2e-kops-aws
/test pull-kubernetes-e2e-gce

@pontiyaraja
Copy link
Contributor Author

/test pull-kubernetes-e2e-kops-aws

7 similar comments
@pontiyaraja
Copy link
Contributor Author

/test pull-kubernetes-e2e-kops-aws

@pontiyaraja
Copy link
Contributor Author

/test pull-kubernetes-e2e-kops-aws

@pontiyaraja
Copy link
Contributor Author

/test pull-kubernetes-e2e-kops-aws

@pontiyaraja
Copy link
Contributor Author

/test pull-kubernetes-e2e-kops-aws

@pontiyaraja
Copy link
Contributor Author

/test pull-kubernetes-e2e-kops-aws

@pontiyaraja
Copy link
Contributor Author

/test pull-kubernetes-e2e-kops-aws

@pontiyaraja
Copy link
Contributor Author

/test pull-kubernetes-e2e-kops-aws

@BenTheElder
Copy link
Member

please just use /skip, note that pull-kubernetes-e2e-kops-aws is not required now and cannot pass, the AWS account is flagged for billing. it will not block merging.

@pontiyaraja
Copy link
Contributor Author

@BenTheElder thank you

@pontiyaraja
Copy link
Contributor Author

/skip pull-kubernetes-e2e-kops-aws

@pontiyaraja
Copy link
Contributor Author

/skip
/skip pull-kubernetes-e2e-kops-aws

msau42
msau42 reviewed Feb 4, 2019
View reviewed changes
Copy link
Member

@msau42 msau42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one minor comment, otherwise lgtm

@pontiyaraja pontiyaraja force-pushed the shared_volumes branch 2 times, most recently from eef36f5 to c8df044 Compare February 5, 2019 05:57
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 5, 2019 •
edited
Loading

@pontiyaraja: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-kops-aws 4fb4f9f91a6b9c9b2829931116b238d8cd37a698 link /test pull-kubernetes-e2e-kops-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pontiyaraja
Copy link
Contributor Author

/test pull-kubernetes-kubemark-e2e-gce-big

msau42
msau42 reviewed Feb 5, 2019
View reviewed changes
msau42
msau42 reviewed Feb 6, 2019
View reviewed changes
@msau42
Copy link
Member

msau42 commented Feb 7, 2019

/lgtm
Thanks for adding this test case!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 7, 2019
@pontiyaraja
Copy link
Contributor Author

pontiyaraja commented Feb 7, 2019 •
edited
Loading

@msau42 can you approve this PR

jayunit100
jayunit100 reviewed Feb 8, 2019
View reviewed changes
test/e2e/common/empty_dir.go
@@ -205,6 +206,77 @@ var _ = Describe("[sig-storage] EmptyDir volumes", func() {
framework.ConformanceIt("should support (non-root,0777,default) [LinuxOnly] [NodeConformance]", func() {
doTest0777(f, testImageNonRootUid, v1.StorageMediumDefault)
})

It("pod should support shared volumes between containers", func() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we propose this for ConformanceIT ? BTW a nice follow on issue might be to add 'EmptyDir' to all these test descriptions. This is a great test esp w/ diverging container runtimes, thanks !

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make sure the test is stable first before promoting to conformance.

EmptyDir is already specified at the top level describe for these tests.

@msau42
Copy link
Member

msau42 commented Feb 8, 2019

/approve

timothysc
timothysc reviewed Feb 8, 2019
View reviewed changes
Copy link
Member

@timothysc timothysc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kind of think this is more complicated then it needs to be.

You could just use a busybox conatiner for both where one container drops a file while the other waits.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Feb 12, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msau42, pontiyaraja

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 12, 2019
@vikaschoudhary16
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 12, 2019
@k8s-ci-robot k8s-ci-robot merged commit dc20f64 into kubernetes:master Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timothysc timothysc timothysc left review comments

@jayunit100 jayunit100 jayunit100 left review comments

@msau42 msau42 msau42 left review comments

@BenTheElder BenTheElder Awaiting requested review from BenTheElder

@shyamjvs shyamjvs Awaiting requested review from shyamjvs

Assignees

@vikaschoudhary16 vikaschoudhary16

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance Issues or PRs related to kubernetes conformance tests cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tracking Issue - Conformance Coverage for Shared Volumes between Containers in a Pod
7 participants
@pontiyaraja @BenTheElder @k8s-ci-robot @msau42 @vikaschoudhary16 @timothysc @jayunit100