Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add priority class to CoreDNS pods #73649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 12, 2019
Merged

Add priority class to CoreDNS pods #73649

merged 3 commits into from
Feb 12, 2019

Conversation

ojmhetar
Copy link
Contributor

@ojmhetar ojmhetar commented Feb 1, 2019

What type of PR is this?
/kind bug

What this PR does / why we need it:
Adds priorityClassName to give preference in scheduling CoreDNS pods over less critical pods.

Which issue(s) this PR fixes:
Fixes kubernetes/kubeadm#1337

Special notes for your reviewer:
I realize that we might want to wait until some of the issues in CoreDNS are addressed. At some point, CoreDNS should have the same priority as kube-dns as a default, cluster critical component.

Does this PR introduce a user-facing change?:

NONE

cc @timothysc

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 1, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @ojmhetar. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 1, 2019
@k8s-ci-robot k8s-ci-robot requested review from bowei and MrHohn February 1, 2019 21:29
@k8s-ci-robot k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 1, 2019
@MrHohn
Copy link
Member

MrHohn commented Feb 1, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 1, 2019
@MrHohn
Copy link
Member

MrHohn commented Feb 1, 2019

/approve
/assign @rajansandeep @chrisohaver

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 1, 2019
neolit123
neolit123 reviewed Feb 3, 2019
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold
/priority important-longterm

this PR is not updating the coredns manifests in kubeadm, but it links to a kubeadm issue:
https://github.com/kubernetes/kubernetes/blob/master/cmd/kubeadm/app/phases/addons/dns/manifests.go

also not sure we ended up agreeing that we should do this for kubeadm.
/assign @fabriziopandini @timothysc

we might decide to scope this to the cluster folder only?

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 3, 2019
@k8s-ci-robot k8s-ci-robot added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 3, 2019
@ojmhetar
Copy link
Contributor Author

ojmhetar commented Feb 4, 2019

My mistake. Should I file a separate issue for this?

@neolit123
Copy link
Member

historically we'e made such updates in the same PR for all deployers.

@fabriziopandini fabriziopandini mentioned this pull request Feb 5, 2019
Closed
@fabriziopandini
Copy link
Member

XREF kubernetes/kubeadm#1291
This problem does not affect only CoreDNS

@neolit123
Copy link
Member

neolit123 commented Feb 5, 2019 •
edited
Loading

EDITED: confused 1337 / 1291.

@ojmhetar
Copy link
Contributor Author

ojmhetar commented Feb 5, 2019

Are there reasons to scope this to the cluster folder? Otherwise, I can update this PR to include the manifest in kubeadm.

@timothysc
Copy link
Member

@ojmhetar - please update this PR to modify the kubeadm manifests as well.

@k8s-ci-robot k8s-ci-robot added area/kubeadm and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 6, 2019
@ojmhetar
Copy link
Contributor Author

ojmhetar commented Feb 6, 2019

fixed for coredns. I see that the same is missing for kubedns, do we want to address that here?

@yagonobre
Copy link
Member

@ojmhetar IMO you should add it to kubedns as well.

rajansandeep
rajansandeep reviewed Feb 7, 2019
View reviewed changes
Copy link
Contributor

@rajansandeep rajansandeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes for kube-dns should be done in the cluster folder as well.

@ojmhetar
Copy link
Contributor Author

ojmhetar commented Feb 7, 2019

@rajansandeep kubedns already has these changes since 1.11:
https://github.com/kubernetes/kubernetes/blob/release-1.11/cluster/addons/dns/kube-dns/kube-dns.yaml.base#L88

@rajansandeep
Copy link
Contributor

@ojmhetar Sorry, that part skipped by me.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 7, 2019
@ojmhetar
Copy link
Contributor Author

ojmhetar commented Feb 7, 2019

no worries! 😄

@ojmhetar ojmhetar mentioned this pull request Feb 7, 2019
Open
@timothysc
Copy link
Member

/approve

  • from kubeadm side.

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 8, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MrHohn, ojmhetar, timothysc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 8, 2019
@ojmhetar
Copy link
Contributor Author

ojmhetar commented Feb 8, 2019

/test pull-kubernetes-integration

@fabriziopandini fabriziopandini mentioned this pull request Feb 11, 2019
Merged
@dims
Copy link
Member

dims commented Feb 12, 2019

/test pull-kubernetes-cross
/test pull-kubernetes-godeps

@ojmhetar
Copy link
Contributor Author

/test pull-kubernetes-integration

@k8s-ci-robot k8s-ci-robot merged commit aa00afe into kubernetes:master Feb 12, 2019
@chrisohaver chrisohaver mentioned this pull request Feb 15, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neolit123 neolit123 neolit123 left review comments

@rajansandeep rajansandeep rajansandeep left review comments

@bowei bowei Awaiting requested review from bowei

@MrHohn MrHohn Awaiting requested review from MrHohn

Assignees

@timothysc timothysc

@fabriziopandini fabriziopandini

@chrisohaver chrisohaver

@rajansandeep rajansandeep

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CoreDNS pods lack a positive priority value (no priority class specified)
10 participants
@ojmhetar @k8s-ci-robot @MrHohn @neolit123 @fabriziopandini @timothysc @yagonobre @rajansandeep @dims @chrisohaver