Refactor to allow for a way to get list of e2e images #74603
Conversation
|
Hi @stevesloka. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/assign @timothysc |
|
/ok-to-test |
|
@timothysc I added a method |
|
Here's an example: |
|
@stevesloka we should probably also expose via the e2e.test artifact as well. |
|
If you want todo that in a separate PR, I'm ok with that. |
b962105 to
321d017
Compare
|
/retest |
073b174 to
294cd63
Compare
|
/test pull-kubernetes-e2e-gce |
294cd63 to
8d15ee0
Compare
|
/retest |
| NoSnatTestProxy = Config{e2eRegistry, "no-snat-test-proxy", "1.0"} | ||
| const ( | ||
| // CRDConversionWebhook image | ||
| CRDConversionWebhook = iota |
There was a problem hiding this comment.
why not map by image-name:image-tag instead of enum values?
edit: NVM
test/utils/image/manifest.go
Outdated
| func initImageConfigs() map[int]Config { | ||
| configs := map[int]Config{} | ||
| configs[CRDConversionWebhook] = Config{e2eRegistry, "crd-conversion-webhook", "1.13rev2"} | ||
| configs[AdmissionWebhook] = Config{e2eRegistry, "webhook", "1.13v1"} |
There was a problem hiding this comment.
this value changed; possible cause for the failures.
08167f9 to
ea99135
Compare
|
@timothysc I've got the CI tests all fixed up now and also added an arg to |
test/e2e/framework/test_context.go
Outdated
| @@ -37,6 +37,9 @@ import ( | |||
|
|
|||
| const defaultHost = "http://127.0.0.1:8080" | |||
|
|
|||
| // ListImages will list off all images that are used then quit | |||
| var ListImages bool | |||
There was a problem hiding this comment.
This seems weirdly global vs adding to the context object.
There was a problem hiding this comment.
I moved it to the test context object. My initial thought was this isn't really part of a test, so it didn't belong there.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: stevesloka, timothysc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Steve Sloka <[email protected]>
|
/hold cancel |
|
@stevesloka: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This adds the ability to get a list of images used for E2E tests. This is needed to help support environments where users would want to understand what images are being used, and also to be able to push to a private registry for air-gapped style environments.
Additionally, this adds a new flag to
e2e.test(--list-images) which allows for the same list to be printed out.Does this PR introduce a user-facing change?:
Signed-off-by: Steve Sloka [email protected]