Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add 1.14 branches for the publishing-bot #74664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 4, 2019
Merged

Add 1.14 branches for the publishing-bot #74664

merged 1 commit into from
Mar 4, 2019

Conversation

dims
Copy link
Member

@dims dims commented Feb 27, 2019

Change-Id: Id34d1f12361e587e02f7dba077a9600618737878

What type of PR is this?
/kind feature

What this PR does / why we need it:
Line up the upcoming release

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 27, 2019
@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 27, 2019
nikhita
nikhita reviewed Feb 27, 2019
View reviewed changes
nikhita
nikhita reviewed Feb 27, 2019
View reviewed changes
@nikhita
Copy link
Member

nikhita commented Feb 27, 2019

@dims thanks for this! This skipped my mind -- we should probably write down the list of things needed to be done for each release somewhere. I have most of it scattered across issues so I'll try to do that later.

@dims dims force-pushed the prepare-publishing-bot-for-1.14-branch branch from fedf4e0 to 6d6b901 Compare February 27, 2019 15:48
@dims
Copy link
Member Author

dims commented Feb 27, 2019

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 27, 2019
nikhita
nikhita reviewed Feb 27, 2019
View reviewed changes
@dims dims force-pushed the prepare-publishing-bot-for-1.14-branch branch from 6d6b901 to eb615ca Compare February 27, 2019 15:54
nikhita
nikhita reviewed Feb 27, 2019
View reviewed changes
@dims dims force-pushed the prepare-publishing-bot-for-1.14-branch branch 2 times, most recently from 09f5d66 to 21876d4 Compare February 27, 2019 16:01
@dims
Copy link
Member Author

dims commented Feb 27, 2019

Thanks for the super quick reviews @nikhita hopefully i fixed all the issues so far!

nikhita
nikhita reviewed Feb 27, 2019
View reviewed changes
@nikhita
Copy link
Member

nikhita commented Feb 27, 2019

@dims last comment but lgtm otherwise.

yaml is hard. :)

@sttts
Copy link
Contributor

sttts commented Feb 27, 2019

component-base is missing, isn't it?

@dims can you do a smoke test run?

@nikhita nikhita mentioned this pull request Feb 27, 2019
Merged
@dims
Copy link
Member Author

dims commented Feb 27, 2019

@sttts how do you do that usually? kubernetes-nightly or kubernetes configuration? What configuration edits are needed?

@sttts
Copy link
Contributor

sttts commented Mar 1, 2019

@dims second copy of the main config, but with dry-run. Nightly would work as well. I hope we can pass a rules URL of the branch.

@dims
Copy link
Member Author

dims commented Mar 1, 2019

Here's the diff i am using:

diff --git a/configs/kubernetes-nightly b/configs/kubernetes-nightly
index 754c43ad959a..d0f3400e4b3e 100644
--- a/configs/kubernetes-nightly
+++ b/configs/kubernetes-nightly
@@ -1,4 +1,4 @@
-DOCKER_REPO = sttts/k8s-publishing-bot-nightly
+DOCKER_REPO = dims/k8s-publishing-bot-nightly
 NAMESPACE = k8s-publishing-bot-nightly
 SCHEDULE = * */4 * * *
 INTERVAL = 14400
diff --git a/configs/kubernetes-nightly-configmap.yaml b/configs/kubernetes-nightly-configmap.yaml
index f2cb0e54c9ef..c26fca64ed0f 100644
--- a/configs/kubernetes-nightly-configmap.yaml
+++ b/configs/kubernetes-nightly-configmap.yaml
@@ -7,6 +7,6 @@ data:
     source-org: kubernetes
     source-repo: kubernetes
     target-org: kubernetes-nightly
-    rules-file: https://raw.githubusercontent.com/kubernetes/kubernetes/master/staging/publishing/rules.yaml
+    rules-file: https://raw.githubusercontent.com/dims/kubernetes/prepare-publishing-bot-for-1.14-branch-%2B244-%E2%88%920/staging/publishing/rules.yaml
     # github-issue: 56876
-    dry-run: false
+    dry-run: true

Here's what i am running:

hack/fetch-all-latest-and-push.sh kubernetes-nightly
make build-image push-image CONFIG=configs/kubernetes-nightly
make run CONFIG=configs/kubernetes-nightly

watching the logs now...

@dims
Copy link
Member Author

dims commented Mar 1, 2019

/test pull-kubernetes-integration

@dims
Copy link
Member Author

dims commented Mar 1, 2019

@sttts @nikhita ended in failure - http://paste.openstack.org/raw/746610/

@dims dims force-pushed the prepare-publishing-bot-for-1.14-branch branch 2 times, most recently from 510470a to b091727 Compare March 4, 2019 13:06
nikhita
nikhita reviewed Mar 4, 2019
View reviewed changes
nikhita
nikhita reviewed Mar 4, 2019
View reviewed changes
@dims
Add 1.14 branches for the publishing-bot
5616e23 
Change-Id: Id34d1f12361e587e02f7dba077a9600618737878
@dims dims force-pushed the prepare-publishing-bot-for-1.14-branch branch from b091727 to 5616e23 Compare March 4, 2019 13:44
@dims
Copy link
Member Author

dims commented Mar 4, 2019

/test pull-kubernetes-integration

@dims
Copy link
Member Author

dims commented Mar 4, 2019

/test pull-kubernetes-e2e-gce-100-performance

nikhita
nikhita approved these changes Mar 4, 2019
View reviewed changes
Copy link
Member

@nikhita nikhita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

/hold
will let @sttts cancel the hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 4, 2019
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 4, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, nikhita

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sttts
Copy link
Contributor

sttts commented Mar 4, 2019

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 4, 2019
@k8s-ci-robot k8s-ci-robot merged commit 8770e0c into kubernetes:master Mar 4, 2019
@nikhita nikhita mentioned this pull request Mar 4, 2019
Merged
This was referenced Mar 4, 2019
Closed
Closed
@nikhita nikhita mentioned this pull request Mar 6, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikhita nikhita nikhita approved these changes

@sttts sttts Awaiting requested review from sttts

Assignees

@nikhita nikhita

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/release Categorizes an issue or PR as relevant to SIG Release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dims @nikhita @sttts @k8s-ci-robot