Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix golint failures in test/e2e/instrumentation, test/e2e_node/environment #74700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 4, 2019
Merged

Fix golint failures in test/e2e/instrumentation, test/e2e_node/environment #74700

merged 1 commit into from
Mar 4, 2019

Conversation

SataQiu
Copy link
Member

@SataQiu SataQiu commented Feb 28, 2019

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Fix golint failures in test/e2e/instrumentation, test/e2e_node/environment
Which issue(s) this PR fixes:
Ref #68026

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 28, 2019
@ConnorDoyle
Copy link
Contributor

ConnorDoyle commented Feb 28, 2019 •
edited
Loading

/approve
/lgtm

(for e2e_node)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 28, 2019
@SataQiu
Copy link
Member Author

SataQiu commented Mar 1, 2019

/assign @vishh

@SataQiu
Copy link
Member Author

SataQiu commented Mar 4, 2019

/assign @cblecker @DirectXMan12 @sttts

@DirectXMan12
Copy link
Contributor

/lgtm
/approve

1 similar comment
@vishh
Copy link
Contributor

vishh commented Mar 4, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ConnorDoyle, DirectXMan12, SataQiu, vishh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2019
@k8s-ci-robot k8s-ci-robot merged commit 5756eea into kubernetes:master Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer Awaiting requested review from feiskyer

@lavalamp lavalamp Awaiting requested review from lavalamp

Assignees

@DirectXMan12 DirectXMan12

@ConnorDoyle ConnorDoyle

@sttts sttts

@cblecker cblecker

@vishh vishh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@SataQiu @ConnorDoyle @DirectXMan12 @vishh @k8s-ci-robot @sttts @cblecker