Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Revert "Use consistent imageRef during container startup" #78316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 31, 2019
Merged

Revert "Use consistent imageRef during container startup" #78316

merged 1 commit into from
May 31, 2019

Conversation

tallclair
Copy link
Member

Automated cherry pick of #78261 upstream release 1.14

What type of PR is this?
/kind bug

What this PR does / why we need it:

This reverts commit 26e3c86 from #76665

The change broke the detection of user ID.

Does this PR introduce a user-facing change?:

Fix broken detection of non-root image user ID

/sig node
/assign @yujuhong
/priority critical-urgent

@tallclair tallclair added this to the v1.14 milestone May 24, 2019
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/node Categorizes an issue or PR as relevant to SIG Node. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 24, 2019
@tallclair tallclair mentioned this pull request May 24, 2019
Closed
@k8s-ci-robot k8s-ci-robot requested review from sjpotter and tmrts May 24, 2019 20:27
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tallclair

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 24, 2019
@yujuhong
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 24, 2019
@yujuhong
Copy link
Contributor

Need to patch 1.13 as well.

@ialidzhikov
Copy link
Contributor

Need to patch 1.13 as well.

Automated cherry-pick for release-1.13 proposed - #78322.

mattjmcnaughton
mattjmcnaughton approved these changes May 25, 2019
View reviewed changes
Copy link
Contributor

@mattjmcnaughton mattjmcnaughton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@verwilst
Copy link

What's keeping this from being merged?

@mattjmcnaughton
Copy link
Contributor

What's keeping this from being merged?

My understanding is all cherry-picks need approval from the branch maintainer, and my guess is just they haven't gotten to this cherry-pick yet :)

@tallclair
Copy link
Member Author

/assign @aleksandra-malinowska @tpepper

@cahoonpwork cahoonpwork mentioned this pull request May 28, 2019
Closed
@aleksandra-malinowska aleksandra-malinowska removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label May 30, 2019
@aleksandra-malinowska aleksandra-malinowska added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label May 30, 2019
@tpepper
Copy link

tpepper commented May 30, 2019

/retest

@liggitt liggitt mentioned this pull request May 30, 2019
Closed
@tpepper
Copy link

tpepper commented May 31, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit 0202641 into kubernetes:release-1.14 May 31, 2019
@liggitt liggitt mentioned this pull request Jun 6, 2019
Closed
@warmchang warmchang mentioned this pull request Jun 7, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjpotter sjpotter Awaiting requested review from sjpotter

@tmrts tmrts Awaiting requested review from tmrts

1 more reviewer

@mattjmcnaughton mattjmcnaughton mattjmcnaughton approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@tpepper tpepper

@mattjmcnaughton mattjmcnaughton

@aleksandra-malinowska aleksandra-malinowska

@yujuhong yujuhong

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet area/security cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.14
Development

Successfully merging this pull request may close these issues.
9 participants
@tallclair @k8s-ci-robot @yujuhong @ialidzhikov @verwilst @mattjmcnaughton @tpepper @liggitt @aleksandra-malinowska