Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

0xmichalis
Copy link
Contributor

Plus:

  • Rename flag --service-name to --name
  • Some refactoring

@rjnagal
Copy link
Contributor

rjnagal commented May 13, 2015

Integration tests are failing. Tests are still using service-name

NAME LABELS SELECTOR IP(S) PORT(S)
frontend name=frontend 80/TCP
Successful get service frontend {{(index .spec.ports 0).port}}: 80
Error: unknown flag: --service-name
Run 'kubectl help' for usage.
!!! Error in ./hack/test-cmd.sh:536
'kubectl expose service frontend --port=443 --service-name=frontend-2 "${kube_flags[@]}"' exited with status 1
Call stack:
1: ./hack/test-cmd.sh:536 main(...)
Exiting with status 1
+++ [0513 14:14:25] Clean up complete

@0xmichalis
Copy link
Contributor Author

@rjnagal don't know what I was thinking while submitting the PR yesterday. Updated all --service-name instances to --name. Thanks

@bprashanth
Copy link
Contributor

@Kargakis Is there an issue I can refer to for context?

@0xmichalis
Copy link
Contributor Author

@Kargakis Is there an issue I can refer to for context?

@bprashanth if I knew of any I would have added it in the commit message;)

@j3ffml
Copy link
Contributor

j3ffml commented May 15, 2015

LGTM. Needs rebase.

@0xmichalis
Copy link
Contributor Author

rebased

@0xmichalis
Copy link
Contributor Author

rebased vol.2

can we get this merged now?

@j3ffml
Copy link
Contributor

j3ffml commented May 20, 2015

Shippable is flake, but travis green. Merging.

@j3ffml
Copy link
Contributor

j3ffml commented May 20, 2015

Sorry, not merging. There's a freeze in place, will merge afterwards. Kicking shippable in the meantime.

@j3ffml j3ffml added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 20, 2015
@j3ffml
Copy link
Contributor

j3ffml commented May 20, 2015

hmmm. hack/test-cmd.sh appears to be failing on shippable.

I0520 17:49:30.970537   21142 manager.go:151] Version: {KernelVersion:3.13.0-43-generic ContainerOsVersion:Ubuntu precise (12.04.5 LTS) DockerVersion:Unknown CadvisorVersion:0.13.0}
I0520 17:49:30.971377   21142 plugins.go:69] No cloud provider specified.
W0520 17:49:31.519457   21142 server.go:535] No api server defined - no events will be sent to API server.
!!! [0520 17:49:36] Timed out waiting for http://127.0.0.1:10248/healthz
!!! Error in ./hack/test-cmd.sh:43
  'return 1' exited with status 1

If it's passing for you locally, you may want to rebase again :/

@j3ffml j3ffml removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 20, 2015
Plus:
* Rename flag --service-name to --name
* Some refactoring
@0xmichalis
Copy link
Contributor Author

Still that fail on shippable? It's confusing that travis is green.

@j3ffml
Copy link
Contributor

j3ffml commented May 22, 2015

Kicked shippable. LGTM.

@j3ffml j3ffml added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 22, 2015
dchen1107 added a commit that referenced this pull request May 22, 2015
@dchen1107 dchen1107 merged commit cc6a313 into kubernetes:master May 22, 2015
@0xmichalis 0xmichalis deleted the expose-use-resource-builder branch May 22, 2015 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants