-
Notifications
You must be signed in to change notification settings - Fork 41.5k
expose: Use resource builder #8169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expose: Use resource builder #8169
Conversation
Integration tests are failing. Tests are still using service-name NAME LABELS SELECTOR IP(S) PORT(S) |
@rjnagal don't know what I was thinking while submitting the PR yesterday. Updated all |
@Kargakis Is there an issue I can refer to for context? |
@bprashanth if I knew of any I would have added it in the commit message;) |
LGTM. Needs rebase. |
rebased |
rebased vol.2 can we get this merged now? |
Shippable is flake, but travis green. Merging. |
Sorry, not merging. There's a freeze in place, will merge afterwards. Kicking shippable in the meantime. |
hmmm.
If it's passing for you locally, you may want to rebase again :/ |
Plus: * Rename flag --service-name to --name * Some refactoring
Still that fail on shippable? It's confusing that travis is green. |
Kicked shippable. LGTM. |
expose: Use resource builder
Plus:
--service-name
to--name