Added Hover to Views Menu in Web UI #8548
Conversation
There was a problem hiding this comment.
Why is this commented out? Will it ever be uncommented? What's the TODO here? (and elsewhere)
There was a problem hiding this comment.
@bgrant0607 This is commented out to fix an issue in the angular directive where the first option remains in focus, even after you mouseover to a different option. It is fixed in the compiled source and is there for reference.
There was a problem hiding this comment.
Please convert it to an explanatory comment rather than leaving it as commented-out code.
|
@bgrant0607, assigning this to you since you've already started reviewing |
|
@jackgr please review |
|
@jackgr @bgrant0607, updated and ready for review |
|
👍 |
|
Please rebase it thanks! |
|
@dchen1107 rebasing now |
|
@dchen1107 I've rebased and it's ready for merge |
|
@dchen1107 I see you just merged the breadcrumb fix, rebasing again |
|
@dchen1107 rebased and ready for merge |
Added Hover to Views Menu in Web UI
Added a css hover state to the views menu in the subnav.
@bgrant0607 highlighted the issue in a comment on #7122
cc/ @jackgr @lavalamp