Fix ordering of conversion methods so that it's deterministic #8577
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
@wojtek-t, you have to rebase to get this merged now. Sorry about this. |
|
My #8552 depends on this one first. On Thu, May 21, 2015 at 9:42 AM, Dawn Chen [email protected] wrote:
|
|
@thockin, yes, I notice it. Thanks! |
dc367d9 to
de0a1d1
Compare
|
Rebased. |
|
Thanks will merge it once shippable is green. |
|
Shippable is green :) |
dchen1107
added a commit
that referenced
this pull request
May 21, 2015
Fix ordering of conversion methods so that it's deterministic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug was exposed by @thockin in #8552
cc @thockin @lavalamp @smarterclayton