Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update pod pages to v1beta3 in web ui #8600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 27, 2015
Merged

Update pod pages to v1beta3 in web ui #8600

merged 1 commit into from
May 27, 2015

Conversation

bcbroussard
Copy link
Contributor

bgrant0607
bgrant0607 reviewed May 21, 2015
View reviewed changes
www/app/assets/js/app.js Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not pod.spec.host? That's the field set by the scheduler.

@bcbroussard
Copy link
Contributor Author

@bgrant0607 - The pod files have been updated to use host instead of hostIP, and the mocks have been changed in the other PR #8304 as well.

caesarxuchao
caesarxuchao reviewed May 21, 2015
View reviewed changes
www/app/assets/js/app.js Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be pod.status.ContainerStatuses[container.name].restartCount

@k8s-bot
Copy link

k8s-bot commented May 21, 2015

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain @ixdy.

@caesarxuchao
Copy link
Contributor

@bcbroussard, I think I have review all your PRs that are assigned to me. Ping me if I left any.

@bcbroussard
Copy link
Contributor Author

Thanks @caesarxuchao. I've made those two updates.

@caesarxuchao
Copy link
Contributor

Thank you @bcbroussard, LGTM

@caesarxuchao caesarxuchao added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 22, 2015
@thockin
Copy link
Member

thockin commented May 27, 2015

needs rebase

@bgrant0607
Copy link
Member

I'd like to get all of the v1beta3-related PRs ASAP, prior to the 0.18 cut. Please rebase.

@thockin
Copy link
Member

thockin commented May 27, 2015

rebase

@bcbroussard
Copy link
Contributor Author

@thockin rebased

thockin added a commit that referenced this pull request May 27, 2015
@thockin
Merge pull request #8600 from bcbroussard/v1beta3-pods
78621f9 
Update pod pages to v1beta3 in web ui
@thockin thockin merged commit 78621f9 into kubernetes:master May 27, 2015
@bcbroussard bcbroussard deleted the v1beta3-pods branch May 28, 2015 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@caesarxuchao caesarxuchao

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bcbroussard @k8s-bot @caesarxuchao @thockin @bgrant0607 @googlebot