Thanks to visit codestin.com
Credit goes to github.com

Skip to content

quick fix to global (and possibly shadowing) client var #8638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 21, 2015
Merged

quick fix to global (and possibly shadowing) client var #8638

merged 1 commit into from
May 21, 2015

Conversation

jayunit100
Copy link
Member

Hey guys ! I mistakenly added a global client variable a while back , was just dutifully noticed by folks in #8630 .

It turns out that this is being used by a few of the tests on accident - people just imported it without checking where it was coming from.

Lets clean this guy up ! heres a PR its untested (still wrapping my head around the new e2e command line options), but i think it will work perfectly.

@jayunit100
Copy link
Member Author

@roberthbailey @justinsb thanks for noting this !

@jayunit100 jayunit100 changed the title quick fix to shadowed client var quick fix to global (and possibly shadowing) client var May 21, 2015
@jayunit100
Copy link
Member Author

okay, tested... working for me.

INFO: Waiting for pod 'nettest-0' in namespace 'e2e-tests-nettest-36862170-37c7-4ba6-8c02-f7cc55973ecd' status to be '"running"' (found phase: '"Pending"', readiness: false) (5.393882ms)
INFO: Waiting for pod 'nettest-0' in namespace 'e2e-tests-nettest-36862170-37c7-4ba6-8c02-f7cc55973ecd' status to be '"running"' (found phase: '"Pending"', readiness: false) (5.009457722s)
INFO: Waiting for pod 'nettest-0' in namespace 'e2e-tests-nettest-36862170-37c7-4ba6-8c02-f7cc55973ecd' status to be '"running"' (found phase: '"Pending"', readiness: false) (10.013576837s)
STEP: Waiting for connectivity to be verified
INFO: About to make a proxy status call
INFO: Proxy status call returned in 2.034207ms
INFO: Attempt 0/60: test still running
INFO: About to make a proxy status call
INFO: Proxy status call returned in 2.186532ms
INFO: Attempt 1/60: test still running
INFO: About to make a proxy status call
INFO: Proxy status call returned in 2.192547ms
INFO: Passed on attempt 2. Cleaning up.
STEP: Cleaning up the webserver pods
STEP: Cleaning up the service
[AfterEach] Networking
  /home/jay/gopath/src/github.com/GoogleCloudPlatform/kubernetes/_output/local/go/src/github.com/GoogleCloudPlatform/kubernetes/test/e2e/networking.go:112
STEP: Destroying namespace for this suite e2e-tests-nettest-36862170-37c7-4ba6-8c02-f7cc55973ecd

• [SLOW TEST:21.344 seconds]
Networking
/home/jay/gopath/src/github.com/GoogleCloudPlatform/kubernetes/_output/local/go/src/github.com/GoogleCloudPlatform/kubernetes/test/e2e/networking.go:263
  should function for intra-pod communication
  /home/jay/gopath/src/github.com/GoogleCloudPlatform/kubernetes/_output/local/go/src/github.com/GoogleCloudPlatform/kubernetes/test/e2e/networking.go:261
------------------------------
SSSSSSSSSS
Ran 2 of 49 Specs in 21.714 seconds
SUCCESS! -- 2 Passed | 0 Failed | 0 Pending | 47 Skipped PASS
[jay@rhbd kubernetes]$ _output/local/bin/linux/amd64/e2e.test  --provider="local" --host="http://127.0.0.1:8080" -ginkgo.focus="Shell*" -kubeconfig=/opt/kube-creds --ginkgo.v=true 2>&1            
>>> testContext.KubeConfig: /opt/kube-creds
INFO: Waiting up to 10m0s for all pods (need at least 0) in namespace 'default' to be running and ready
INFO: 0 / 0 pods in namespace 'default' are running and ready (2.135081ms elapsed)
Running Suite: Kubernetes e2e suite
===================================
Random Seed: 1432245606 - Will randomize all specs
Will run 1 of 49 specs

SSSSSSSSSSS
------------------------------
Shell 
  tests that services.sh passes
  /home/jay/gopath/src/github.com/GoogleCloudPlatform/kubernetes/_output/local/go/src/github.com/GoogleCloudPlatform/kubernetes/test/e2e/shell.go:39
[It] tests that services.sh passes
  /home/jay/gopath/src/github.com/GoogleCloudPlatform/kubernetes/_output/local/go/src/github.com/GoogleCloudPlatform/kubernetes/test/e2e/shell.go:39
STEP: Skipping Shell test services.sh, which is only supported for provider gce and gke (not local)
•SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS
Ran 1 of 49 Specs in 0.001 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 48 Skipped PASS

roberthbailey
roberthbailey reviewed May 21, 2015
View reviewed changes
test/e2e/networking.go Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you keep the variable named 'c' so it's consistent with the rest of the e2e tests?

@jayunit100
Copy link
Member Author

@roberthbailey , implemented your suggestion - good idea to minimize the diffs - done and tested . looks like its working still.

@roberthbailey
Copy link
Contributor

LGTM. Thanks for the quick fix.

@roberthbailey roberthbailey self-assigned this May 21, 2015
roberthbailey added a commit that referenced this pull request May 21, 2015
@roberthbailey
Merge pull request #8638 from jayunit100/fix_c_shadow
d9d12fd 
quick fix to global (and possibly shadowing) client var
@roberthbailey roberthbailey merged commit d9d12fd into kubernetes:master May 21, 2015
@alvaroaleman alvaroaleman mentioned this pull request Dec 19, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@roberthbailey roberthbailey

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jayunit100 @roberthbailey @googlebot