Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

thockin
Copy link
Member

@thockin thockin commented May 22, 2015

@justinsb @vishh @bgrant0607 @jbeda

This should not be committed until Justin's load-balancer rework is in.

docs/services.md Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That hyphen was technically correct, but whatever.

English is right-associative by default, so without the hyphen it's (virtual-IP) (based bridge).

@bgrant0607
Copy link
Member

I still see a lot of references to "portal IP".

docs/services.md Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on each node

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done in next push

@thockin
Copy link
Member Author

thockin commented May 22, 2015

regarding portal: that hasn't been changed yet. I'll followup Justin's LB changes to see if we can do that reasonably and if so re-update the docs.

@justinsb for a read-over to see if I missed anything.

@thockin
Copy link
Member Author

thockin commented May 22, 2015

new push is up

docs/services.md Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quotation problem here (missing closing-double quote)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done in next push

@thockin
Copy link
Member Author

thockin commented May 22, 2015

new push with nits fixed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have to explain the contents of the ingress field?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mentioned it, I don't feel like we need to go into too much depth here right now.

@thockin
Copy link
Member Author

thockin commented May 22, 2015

New push is up with nits addressed

@a-robinson
Copy link
Contributor

LGTM outside of existing comments

@bgrant0607
Copy link
Member

Do you want this or #8740 to be merged first?

@thockin
Copy link
Member Author

thockin commented May 26, 2015

This first

On Tue, May 26, 2015 at 1:25 PM, Brian Grant [email protected]
wrote:

Do you want this or #8740
#8740 to be
merged first?


Reply to this email directly or view it on GitHub
#8655 (comment)
.

@bgrant0607 bgrant0607 added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 26, 2015
@bgrant0607
Copy link
Member

LGTM

@thockin
Copy link
Member Author

thockin commented May 26, 2015

Pushed with a few more "virtual" references removed.

saad-ali added a commit that referenced this pull request May 26, 2015
Update docs about new Services work
@saad-ali saad-ali merged commit 3070b45 into kubernetes:master May 26, 2015
@thockin thockin deleted the lb-type-docs branch June 25, 2015 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants