Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

j3ffml
Copy link
Contributor

@j3ffml j3ffml commented May 26, 2015

Rolled up from 17f6f86.

@j3ffml
Copy link
Contributor Author

j3ffml commented May 26, 2015

Do not merge. Will re-cut after #8833 is in to fix gke-e2e runs.

@bgrant0607
Copy link
Member

cc @thockin @quinton-hoole re. other e2e failures.

@bgrant0607
Copy link
Member

In addition to outstanding e2e failures, we have a backlog of 28 PRs with lgtm, which include the last v1beta1-to-v1beta3 conversions, the last v1 service API change, and some significant kubectl command (run, scale, exec) changes. I'd like to postpone the 0.18 cut until we get these in. In particular, we want to have a release with full v1beta3 support before we rip out v1beta1 and v1beta2. 0.18 was expected to be that release, but the merge freeze interfered with that plan.

cc @caesarxuchao @krousey

@j3ffml
Copy link
Contributor Author

j3ffml commented May 29, 2015

e2e is stable again. re-cut release from 17f6f86. PTAL

@roberthbailey
Copy link
Contributor

LGTM.

@bgrant0607 I believe all of the v1beta3 PRs have been merged prior to the v0.18.0 tag.

@j3ffml
Copy link
Contributor Author

j3ffml commented May 29, 2015

cc @vishh
gke-ci is still a bit flaky (it was broken overnight by #8740), but I'd still like to get this in today so we can get more test coverage over the weekend.

@bgrant0607
Copy link
Member

Yes, thanks. Please cut the release. v1beta1 and v1beta2 will be ripped out first thing Monday morning.

@bgrant0607
Copy link
Member

What was the gke-ci breakage due to, specifically? The env. var. change, flag change, salt change, ...?

@j3ffml
Copy link
Contributor Author

j3ffml commented May 29, 2015

The envvar change broke gke-ci. Robby fixed this morning.

@j3ffml j3ffml assigned rjnagal and unassigned roberthbailey May 29, 2015
@j3ffml
Copy link
Contributor Author

j3ffml commented May 29, 2015

Can has merge?

rjnagal added a commit that referenced this pull request May 29, 2015
@rjnagal rjnagal merged commit fd4a0c5 into kubernetes:master May 29, 2015
@j3ffml j3ffml deleted the release-0.18 branch June 16, 2015 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants