-
Notifications
You must be signed in to change notification settings - Fork 41.5k
Fixed setNodeStatus to allow running on pods on OS X #8826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Why is max pods set to 0 on OSX? Are you running a kubelet built from HEAD? |
@vishh yes, HEAD. Capacity['pods'] wasn't set at all, which was the problem. |
May be the fix is to set max pods when cadvisor is not running? Overall, making kubelet control a docker daemon on another host doesn't On Tue, May 26, 2015 at 1:51 PM, Saad Ali [email protected] wrote:
|
I think this is a scheduling issue, with the scheduler running in a process in OSX just like Kubelet. The node has no pod capacity (CPU and memory set to 0 on line 1836). Are you suggesting I move the fix to that section? I'm looking for advice for how to fix this (if this is a bug worth fixing) :) |
Yes. Can you try setting On Tue, May 26, 2015 at 2:14 PM, Mark Turansky [email protected]
|
@vishh It is moved, per your request. |
LGTM. |
CL fails. |
poke when CI passes and we can LGTM then |
@thockin Poke. Travis just returned green. |
… to kubelet's pod list length
@thockin poke again, rebased, and all returned green (the Jenkins builder flaked last time) |
Fixed setNodeStatus to allow running on pods on OS X
See https://github.com/GoogleCloudPlatform/kubernetes/blob/master/pkg/kubelet/kubelet.go#L1836
When cadvisor is unavailable, the node gets 0 CPU and RAM. Capacity['pods'] does not exist.
Because there is no pod capacity, Kubelet running on OS X and using boot2docker cannot schedule any pods. All fail because there are no pod resources available.
I don't know if this is the correct solution, but it fixes running on OS X.