Fails gofmt

Ref #7018

Updated. PTAL. Thanks.

Doesn't build. Regenerate pkg/api/deep_copy_generated.go

Yeah, I have the problem when I work on #6797 today. It's strange this problem didn't occur yesterday. I will get back to this PR after fixing #6797.

@wojtek-t We're having trouble with the generated conversions. Is it obvious what we're doing wrong?

Hi @wojtek-t, no big deals, I just want to know what's the best practice when one tried to update the api, e.g., update PodSpec.Host to PodSpec.Nodename.

here are the steps that I want to take, but these don't work:

1. change a field name (e.g. Host->NodeName) in api/types.go and api/v1/types.go
2. add functions in v1beta3/conversion.go to convert "Host" in v1beta3 to "NodeName" in internal version
3. run hack/update-generated-conversion.sh and hack/update-generated-deep-copies.sh.
   This doesn't work because in step 3, the scripts complain that the v1beta3/conversion-generated.go and deep-copies_generated.go contain undeclared field name "Host"

So I have to manually update various -generated.go, and then these update- scripts are happy. However, at this point, I have already made all the changes manually, there is no work left for these update-* scripts. Please let me know if there is a better way. Thanks.

Building the generator should not build the previously generated code. That seems wrong.

In cmd/genconversion/conversion.go:

     "github.com/GoogleCloudPlatform/kubernetes/pkg/api"
     _ "github.com/GoogleCloudPlatform/kubernetes/pkg/api/v1"
     _ "github.com/GoogleCloudPlatform/kubernetes/pkg/api/v1beta1"
     _ "github.com/GoogleCloudPlatform/kubernetes/pkg/api/v1beta2"
     _ "github.com/GoogleCloudPlatform/kubernetes/pkg/api/v1beta3"

So to build the generator, it requires the conversion_generated.go files in these packages to be correct.

I understand that's the way it is. I was saying it shouldn't be that way. :-)

The generated code just needs to build, though, right? It doesn't need to work? If you commented out the lines it complained about, would the generator build and then regenerate the conversions?

Yeah, that should work. That seems to be the best option.

@caesarxuchao - yes, unfortunately this is the easiest way to do it. Basically, what you can do is to remove the whole code from */conversions_generated.go files, and running:
hack/update-generated-conversions.sh will regenerate them.
I agree it's not convenient and shouldn't work like this but it's not trivial to fix it.

@wojtek-t Please add that to the instructions.
https://github.com/GoogleCloudPlatform/kubernetes/blob/master/docs/devel/api_changes.md#edit-version-conversions

@bgrant0607 - I thought about it and I know how to fix the problem. Will fix the real issue instead of updating documentation :)

"remove the whole code from */conversions_generated.go" won't work, because some functions in conversion.go depend on code in conversions_generated.go

@wojtek-t, I'm looking forward to your fix : )

@caesarxuchao unfortunately my fix doesn't work because what you wrote. Updated instructions are in #8921

Tests failing:

_output/local/go/src/github.com/GoogleCloudPlatform/kubernetes/pkg/api/deep_copy_generated.go:1377: out.Host undefined (type *PodSpec has no field or method Host)

@bgrant0607 Updated and rebased. Let's wait for the Shippable results. Thanks.

Shippable failed already:

 github.com/GoogleCloudPlatform/kubernetes/test/soak/serve_hostnames
test/soak/serve_hostnames/serve_hostnames.go:188: unknown "github.com/GoogleCloudPlatform/kubernetes/pkg/api".PodSpec field 'Host' in struct literal

There is something wrong in field.selector. I'm taking a look.

@bgrant0607 Shippable is green

Please squash the commits.

LGTM once squashed.

Squashed. Thanks.