Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

bprashanth
Copy link
Contributor

TestNoManualChangesToGenerateDeepCopies fails without, passes with. Maybe this should be a presubmit hook if it isn't already?
@wojtek-t

@wojtek-t
Copy link
Member

That's strange - it's already a pre-commit hook:
https://github.com/GoogleCloudPlatform/kubernetes/blob/master/hooks/pre-commit#L103

@bprashanth
Copy link
Contributor Author

I believe we need generated-deep-copies as well

@thockin
Copy link
Member

thockin commented May 27, 2015

make test passes for me

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@bprashanth
Copy link
Contributor Author

I supposed because of #8870, get it in as a pre-commit?

@googlebot
Copy link

CLAs look good, thanks!

@bprashanth
Copy link
Contributor Author

CLA bot went nuts because i botched a squash

@bprashanth bprashanth changed the title Update generated deep copies Add pre-commit hook to update generated deep copies May 28, 2015
@wojtek-t
Copy link
Member

I also added this hook as part of #8860 - since it's already merged, I'm closing this one.

Anyway - thanks for noticing it.

@wojtek-t wojtek-t closed this May 28, 2015
@bprashanth bprashanth deleted the gen_deepcopy branch October 26, 2015 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants