Introduce framework in e2e services; should log events on failure #8905
Conversation
|
Not sure if we're still having e2e failures around loadbalancer creation, but having this in would make it much easier to track these problems down. (Now that we are logging events) |
|
Sorry for sitting on this review for so long. Is there a reason you updated only "should be able to change the type and nodeport settings of a service" and not the other specs? |
|
No worries on delay. It was intended as a clean-up that would also help capture more information on the e2e lakes. if we're not having the e2e problem flakiness any more , I suggest we just punt this to post v1. I can look at applying it more generally, and generally making these tests a bit neater. |
|
I'm going to this as post-v1; if we're still having the e2e problem we can untag. |
|
@justinsb please rebase |
af00802 to
584a6f2
Compare
Once kubernetes#8887 merges this should show errors in load balancer creation. Even before then, it may show another error. Bug kubernetes#8892
|
GCE e2e build/test passed for commit 584a6f2. |
|
Rebased. I think shippable looks like a flake (failure relates to mesos) |
|
@k8s-bot test this please |
|
Gah.... I'm not sure how to get shippable to retest? |
|
GCE e2e build/test passed for commit 584a6f2. |
|
OK, well shippable did retest. And it is proving useful to have the events while I'm trying to understand why this test is failing (in another branch). |
|
LGTM |
|
did you only update (The shippable retest was me being sneaky and clicking the "rebuild" button without saying so.) |
|
@ixdy yes that is correct. I had intended this as a pretty small commit that we could get in to look into the failures that we were seeing in e2e testing occasionally. Next up would be to integrate some of the functionality of NewWebserverTest into the framework. I wasn't aware of framework when I wrote it, and I think much of NewWebserverTest is duplicative/could be done better by hooking in to framework. |
|
@k8s-bot test this [testing build queue, sorry for the noise] |
|
GCE e2e build/test failed for commit 584a6f2. |
|
@k8s-bot test this [previous run failed; detecting flake.] |
|
GCE e2e build/test passed for commit 584a6f2. |
|
@k8s-bot test this [contrib/submit-queue: candidate for merging] |
|
GCE e2e build/test passed for commit 584a6f2. |
|
Automatic merge from SubmitQueue |
…tion Auto commit by PR queue bot
Once #8887 merges this should show errors in load balancer creation.
Even before then, it may show another error.
Bug #8892