Refactor create deployment and add --port flag #91113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/sig cli |
a9fe301 to
a5c4829
Compare
sftim
reviewed
May 14, 2020
| Port: -1, | ||
| PrintFlags: genericclioptions.NewPrintFlags("created").WithTypeSetter(scheme.Scheme), | ||
| IOStreams: ioStreams, | ||
| } | ||
| } | ||
|
|
||
| // NewCmdCreateDeployment is a macro command to create a new deployment. | ||
| // This command is better known to users as `kubectl create deployment`. | ||
| // Note that this command overlaps significantly with the `kubectl run` command. |
There was a problem hiding this comment.
nit / aside: This line might be out of date now.
|
/hold |
a5c4829 to
172d3c6
Compare
|
Those look like flakes to me |
No worries, I was waiting for #91199 to land first :) |
172d3c6 to
53bc51d
Compare
|
/hold cancel |
|
/retest |
1 similar comment
|
/retest |
|
Seems testing fail with this: Line 200 in f097cee |
53bc51d to
ed1a0e9
Compare
|
Good catch, I missed that bit. I accidentally dropped the |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
/kind feature
What this PR does / why we need it:
This is coming from discussions from #87077 to add
--portflag support forkubectl create deploymentcommand.Special notes for your reviewer:
/assign @sallyom @zhouya0
Does this PR introduce a user-facing change?: