kube-aggregator: sync startup with APIService handlers #93286
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/assign @lavalamp |
|
Some sort of a test would be nice? |
|
|
||
| s.proxyHandlersLock.Lock() | ||
| handled := sets.StringKeySet(s.proxyHandlers) | ||
| s.proxyHandlersLock.Unlock() |
| if s.openAPIAggregationController != nil { | ||
| s.openAPIAggregationController.AddAPIService(proxyHandler, apiService) | ||
| // this is calling a controller. It should already handle being async. | ||
| go func() { |
There was a problem hiding this comment.
this is suspicious. the AddAPIService is merely pushing tasks into queue, we don't need to spawn a new routine, is it?
|
|
||
| import ( | ||
| "fmt" | ||
| "k8s.io/klog/v2" |
|
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
|
/remove-lifecycle stale |
|
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
|
@sttts: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-contributor-experience at kubernetes/community. |
There is a race of the apiserver setting up the api service handlers and reporting readiness. This PR adds a synchronization between two via a post-start hook.
/kind bug