Stop ignoring unit test flakes #93605
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(I expect the unit tests to fail on this, mostly just wanting to flush out failures to open targeted issues) |
|
/sig testing |
|
beat me to it 🙃 |
|
pod pending timeout (prow) for kind :| |
|
I don't think removing this flag invalidates existing flaked-passed results
…On Fri, Jul 31, 2020 at 9:21 AM Jordan Liggitt ***@***.***> wrote:
pull-kubernetes-bazel-test — Job succeeded.
well... that's surprising and encouraging...
—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub
<#93605 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHADK2ZEPICQT5SZLEEGZLR6LVR3ANCNFSM4PQNOCVQ>
.
|
|
we are caching test results
On Fri, Jul 31, 2020 at 9:26 AM Benjamin Elder <[email protected]>
wrote:
… I don't think removing this flag invalidates existing flaked-passed results
On Fri, Jul 31, 2020 at 9:21 AM Jordan Liggitt ***@***.***>
wrote:
> pull-kubernetes-bazel-test — Job succeeded.
>
> well... that's surprising and encouraging...
>
> —
> You are receiving this because you are on a team that was mentioned.
> Reply to this email directly, view it on GitHub
> <#93605 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAHADK2ZEPICQT5SZLEEGZLR6LVR3ANCNFSM4PQNOCVQ>
> .
>
|
|
yay flakes! |
|
FYI we don't need to keep retesting this unless it's jordan running
repeated runs to collect data, it's not going to merge as-is anyhow.
- the atomic ops fix will be in another PR and isn't done yet
- there's a temp commit at the end of this that needs to be removed before
merge
…On Wed, Sep 2, 2020 at 12:35 PM Daniel Smith ***@***.***> wrote:
I think this flag was intended for the "integration" mode
Yeah when I added the retries it was only for the e2e tests (maybe the
integration? I doubt it but not 100% sure). There's no excuse for having
flaky unit tests.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#93605 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHADK3LXUXJSJ4SEYXSFETSD2M6NANCNFSM4PQNOCVQ>
.
|
|
/retest |
1 similar comment
|
/retest |
|
All the often-encountered flakes have been fixed. #93902 (comment) is remaining but is extremely rare. At this point, I think the benefit of merging this and gaining the protection against newly introduced unit test flakes is worthwhile. /hold cancel |
|
What a journey! /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justaugustus, liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Sep 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Flakes and bugs found via this PR:
Fixed + merged:
Unresolved flakes:
Does this PR introduce a user-facing change?:
cc @kubernetes/sig-testing