Use Node IP Address instead of Node.Name in minion.ResourceLocation. #9451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor GetNodeHostIP into pkg/util/node (instead of pkg/util to break import cycle). Include internalIP in gce NodeAddresses.
|
EXPERIMENTAL JENKINS PR BUILDER: e2e build succeeded. |
|
LGTM. |
krousey
added a commit
that referenced
this pull request
Jun 9, 2015
Use Node IP Address instead of Node.Name in minion.ResourceLocation.
justinsb
added a commit
to justinsb/kubernetes
that referenced
this pull request
Sep 29, 2016
Most of our communications from apiserver -> nodes used nodutil.GetNodeHostIP, but a few places didn't - and this meant that the node name needed to be resolvable _and_ we needed to populate valid IP addresses. Fix the last few places that used the NodeName. Issue kubernetes#18525 Issue kubernetes#9451 Issue kubernetes#9728 Issue kubernetes#17643 Issue kubernetes#11543 Issue kubernetes#22063 Issue kubernetes#2462 Issue kubernetes#22109 Issue kubernetes#22770 Issue kubernetes#32286
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor GetNodeHostIP into pkg/util/node (instead of pkg/util to break import cycle).
Include internalIP in gce NodeAddresses (instead of NodeLegacyHostIP).
This addresses #2462 but leaves in support for using NodeLegacyHostIP (if nothing else is there). This doesn't solve the entire problem of needing to present different addresses in different places, but it at least stops using the node's name as an address.