DelegatingAuthenticationOptions TokenReview client timeout #96217
+14
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… TokenReview client that is used by for the webhook authenticator Previously no timeout was set. Requests without explicit timeout might potentially hang forever and lead to starvation of the application. When no timeout was specified a default one will be applied.
ef0c461 to
7340c34
Compare
|
Having a cap here makes sense. This is exposed for code users, but not via flags (which also makes sense) /lgtm |
|
/triage accepted |
|
/hold cancel |
|
/assign @mikedanese for |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheftako, deads2k, p0lyn0mial The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it: This PR allows for setting a timeout for the
TokenReviewclient that is used by thewebhook authenticator. Previously no timeout was set. Requests without explicit timeout might potentially hang forever and lead to starvation of the application. When no timeout was specified a default one will be applied.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: