Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add explanation for kubeClient != nil in NewMainKubelet #97932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 29, 2021
Merged

Add explanation for kubeClient != nil in NewMainKubelet #97932

merged 1 commit into from
Jan 29, 2021

Conversation

ehashman
Copy link
Member

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Adds an explanation for why we check for kubeClient != nil in NewMainKubelet and hence why behaviour is different in each case.

Which issue(s) this PR fixes:

N/A, this was a thing I was confused about and had to ask a question, and would like to document it for future contributors :)

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 11, 2021
@ehashman
Copy link
Member Author

/sig node
/priority backlog
/triage accepted

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 11, 2021
@ehashman
Copy link
Member Author

/cc @troy0820

@k8s-ci-robot k8s-ci-robot requested a review from troy0820 January 11, 2021 23:00
dims
dims approved these changes Jan 11, 2021
View reviewed changes
pkg/kubelet/kubelet.go

var serviceLister corelisters.ServiceLister
var serviceHasSynced cache.InformerSynced
// If kubeClient == nil, we are running in standalone mode (i.e. no API servers)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good one :)

@dims
Copy link
Member

dims commented Jan 11, 2021

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 11, 2021
@ehashman
Copy link
Member Author

Thanks @dims!

@troy0820
Copy link
Member

Thanks for this. It was confusing me as well.
/lgtm

@endocrimes
Copy link
Member

/lgtm
/assign @derekwaynecarr

@mrunalp
Copy link
Contributor

mrunalp commented Jan 28, 2021

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, ehashman, mrunalp, pacoxu, troy0820

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 28, 2021
@k8s-ci-robot k8s-ci-robot merged commit e05c9ab into kubernetes:master Jan 29, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Jan 29, 2021
@troy0820 troy0820 mentioned this pull request Mar 15, 2021
Closed
13 tasks
@troy0820 troy0820 mentioned this pull request Dec 20, 2021
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dims dims dims approved these changes

@Random-Liu Random-Liu Awaiting requested review from Random-Liu

@resouer resouer Awaiting requested review from resouer

+2 more reviewers

@pacoxu pacoxu pacoxu approved these changes

@troy0820 troy0820 troy0820 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@dims dims

@endocrimes endocrimes

@troy0820 troy0820

@derekwaynecarr derekwaynecarr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node: code and documentation PRs
Archived in project
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.
8 participants
@ehashman @dims @troy0820 @endocrimes @mrunalp @k8s-ci-robot @pacoxu @derekwaynecarr