kubelet_test: fixes race in TestSyncPodsDeletesWhenSourcesAreReadyPerQOS #98938
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
103b006 to
86f7ade
Compare
ehashman
reviewed
Feb 10, 2021
pkg/kubelet/kubelet_test.go
Outdated
Comment on lines
456
to
457
There was a problem hiding this comment.
Is there a way to defer these for just the block above? With this change, if something explodes in the code above these won't get called, right?
There was a problem hiding this comment.
The test doesn't return early... so these should always get called.
|
/release-note-none |
|
mm, looks like the test failed Ryan https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/98938/pull-kubernetes-bazel-test/1359296150607237120#1:build-log.txt%3A192 |
|
yeah, it did... let me see. |
86f7ade to
219303f
Compare
219303f to
bb29547
Compare
|
|
|
looks like an unrelated flake /test pull-kubernetes-e2e-kind |
|
/test pull-kubernetes-e2e-kind |
bb29547 to
29fdbb0
Compare
29fdbb0 to
c70ecc2
Compare
c70ecc2 to
ee8ea1b
Compare
|
/approve |
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rphillips, sjenning The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test pull-kubernetes-e2e-kind |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind flake
/kind cleanup
What this PR does / why we need it:
#98424 introduced a unit test called TestSyncPodsDeletesWhenSourcesAreReadyPerQOS. This unit test has a subtle flake in it since the podContainerManager calls Delete() with a go routine.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Verify:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: