fix annoying 'please check...' messages; remove v1beta1&2 ref #9966
+46
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. This was listed in #8087, but wasn't prioritized correctly. |
|
#9854 tries to add the fieldmapping for v1, but this PR seems more comprehensive. |
There was a problem hiding this comment.
PodHost is spec.nodeName in v1.
There was a problem hiding this comment.
that may be true, but this needs updating as well then:
func PodToSelectableFields(pod *api.Pod) fields.Set {
return fields.Set{
"metadata.name": pod.Name,
"spec.host": pod.Spec.NodeName,
"status.phase": string(pod.Status.Phase),
}
}
There was a problem hiding this comment.
if I understand correctly, all of these things have to match:
- the label returned from the
AddFieldLabelConversionFuncfor Pod in all versions - the key returned from
PodToSelectableFields - the value of
client.PodHost
There was a problem hiding this comment.
Good point. Yes, we should fix those.
|
cc @liggitt |
There was a problem hiding this comment.
We should eliminate minions, at least in v1.
|
Tagged with v1.0 because it's part of #7018 that was missed. |
|
GCE e2e build/test passed for commit f990899. |
satnam6502
added a commit
that referenced
this pull request
Jun 19, 2015
based on #9966: fix annoying 'please check...' messages; remove v1beta1&2 ref
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bgrant0607 @caesarxuchao @krousey
Part of this is a thing that was missed in removing v1beta1&2, and also in adding v1.