Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Detect readonly filesystem #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 20, 2018
Merged

Detect readonly filesystem #221

merged 1 commit into from
Nov 20, 2018

Conversation

wangzhen127
Copy link
Member

@wangzhen127 wangzhen127 commented Nov 20, 2018 •
edited
Loading

The PR adds one more rule to kernel monitor to detect read-only filesystem. It also changes the plugin from journald to kmsg, because when filessystem becomes readonly, no new logs can be saved into /var/log. Then journald does not have new data for problem detection.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 20, 2018
@wangzhen127
Copy link
Member Author

/cc @jiayingz
/assign @Random-Liu

@andyxning
Copy link
Member

andyxning commented Nov 20, 2018 •
edited
Loading

@wangzhen127 Have you test that journald do not work properly in a read-only fs? IMHO, journald will read log files under /var/log dir if i remember correctly.

@wangzhen127
Copy link
Member Author

@andyxning, the reading part is fine. The problem is that when fs is read-only, no new logs can be saved into /var/log. Then journald does not have new data for problem detection. Updated the PR description to explain that part.

@Random-Liu
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 20, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Random-Liu, wangzhen127

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 20, 2018
@k8s-ci-robot k8s-ci-robot merged commit 967c22e into kubernetes:master Nov 20, 2018
@wangzhen127 wangzhen127 deleted the readonly-fs branch November 20, 2018 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyxning andyxning Awaiting requested review from andyxning

@Random-Liu Random-Liu Awaiting requested review from Random-Liu

@jiayingz jiayingz Awaiting requested review from jiayingz

Assignees

@Random-Liu Random-Liu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wangzhen127 @andyxning @Random-Liu @k8s-ci-robot