More fix to custom plugin monitor condition change#228
Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom Nov 27, 2018
Merged
More fix to custom plugin monitor condition change#228k8s-ci-robot merged 1 commit intokubernetes:masterfrom
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
Conversation
Member
Author
|
/cc @andyxning |
f0f9972 to
3062622
Compare
Member
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Random-Liu, wangzhen127 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
Author
|
/retest |
Member
|
@wangzhen127 @Random-Liu Please see #200, end users may need a switch to enable condition change when the need to bring some info through message. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
condition.Statusdoes not change, we should checkcondition.Reasoninstead ofcondition.Messagebecause Message could be spammy and change a lot.This is part of #202.