Disable doclint when building with java8 #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The generated javadoc comments in the `models` packages contain several `<` characters which the java8 doclint plugin rejects. Note - this means if you build with java8 you will _not_ have javadocs. Another solution would be to fix the stems for the comments in that package, but I'm not sure how to go about that.
|
Does it worth fixing templates in swagger-codegen? |
|
The comments look quite k8s specific, and it looks like swagger correctly escapes html characters in other places for the javadocs. I'll look into where the bad characters come from. |
|
LGTM, fixing where they come from makes sense, but let's get this building now, I had someone run into this issue... |
|
Here is the proper fix: swagger-api/swagger-codegen#6040 |
|
Can you keep an open issue for this to port it back and revert this PR when your proper fix merged? |
|
Sure thing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generated javadoc comments in the
modelspackages contain several<characters which the java8 doclint plugin rejects. Note - this means if youbuild with java8 you will not have javadocs. Another solution would be
to fix the stems for the comments in that package, but I'm not sure how
to go about that.