Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Improve compatibility-matrix documentation in alignment with client-go #1106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 12, 2020
Merged

Improve compatibility-matrix documentation in alignment with client-go #1106

merged 1 commit into from
Mar 12, 2020

Conversation

roycaihw
Copy link
Member

The existing documentation was inaccurate about version skew. I copied the improved documentation from client-go. I also cut down the size of the matrix to only include the supported versions.

/cc @alanjcastonguay

@roycaihw roycaihw requested a review from palnabarun March 12, 2020 01:48
@k8s-ci-robot
Copy link
Contributor

@roycaihw: GitHub didn't allow me to request PR reviews from the following users: alanjcastonguay.

Note that only kubernetes-client members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

The existing documentation was inaccurate about version skew. I copied the improved documentation from client-go. I also cut down the size of the matrix to only include the supported versions.

/cc @alanjcastonguay

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roycaihw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 12, 2020
@ellieayla
Copy link

Review: Diffs of markdown tables are pretty hard to read. :)

@palnabarun
Copy link
Member

Thanks for simplifying the table and removing the older versions. :)

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 12, 2020
@k8s-ci-robot k8s-ci-robot merged commit cd81466 into kubernetes-client:master Mar 12, 2020
@roycaihw roycaihw deleted the compatibility-matrix branch March 13, 2020 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palnabarun palnabarun Awaiting requested review from palnabarun

Assignees

@palnabarun palnabarun

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@roycaihw @k8s-ci-robot @ellieayla @palnabarun