Refactor tests #115
Merged
Refactor tests #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 94.46% (diff: 100%)@@ master #115 diff @@
==========================================
Files 9 9
Lines 668 668
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 631 631
Misses 37 37
Partials 0 0
|
mbohlool
suggested changes
Jan 26, 2017
kubernetes/e2e_test/base.py
Outdated
| import urllib3 | ||
|
|
||
|
|
||
| def _is_k8s_running(): |
There was a problem hiding this comment.
nit: _ at the start used to hide methods in classes. Here the method is being used in this module and it is not exported in its init.py. Thus I don't see any reason to add _.
| # under the License. | ||
|
|
||
| """ | ||
| test_client |
There was a problem hiding this comment.
Look like the file comment does not match filename and its content. I suggest either update it or delete the comment if you don't think it adds value. Whatever you decide here, we should apply it to the rest of e2e test files.
* separate batch, extensions and the regular apis into separate * added delete for some tests * drop '_' for is_k8s_running * remove comments that do not add value
80dde2d to
38aaec0
Compare
|
@mbohlool Done! |
mbohlool
approved these changes
Jan 26, 2017
yliaog
pushed a commit
to yliaog/client-python
that referenced
this pull request
Jan 8, 2022
Update pycodestyle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.