Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update Release Doc #1229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 21, 2020
Merged

Update Release Doc #1229

merged 4 commits into from
Sep 21, 2020

Conversation

scottilee
Copy link
Contributor

Adds more detail to the release doc and removes a redundant release file.

/assign @palnabarun

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 6, 2020
@k8s-ci-robot k8s-ci-robot requested review from roycaihw and yliaog August 6, 2020 06:54
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 6, 2020
@roycaihw
Copy link
Member

/assign

roycaihw
roycaihw reviewed Sep 9, 2020
View reviewed changes
Copy link
Member

@roycaihw roycaihw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment. LGTM otherwise

devel/release.md Outdated
scripts/update-client.sh
```

Remove the tests directory (ref: https://github.com/kubernetes-client/python/commit/ec9c944f076999543cd2122aff2d86f969d82548).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you move this line to the "hot issues" section, and link to the upstream issue OpenAPITools/openapi-generator#5377?

palnabarun
palnabarun requested changes Sep 15, 2020
View reviewed changes
Copy link
Member

@palnabarun palnabarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me other than what @roycaihw mentioned.

@roycaihw
Copy link
Member

/lgtm
/approve

Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 21, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roycaihw, scottilee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 21, 2020
@k8s-ci-robot k8s-ci-robot merged commit f41b95b into kubernetes-client:master Sep 21, 2020
@scottilee scottilee deleted the releasedocs branch April 30, 2021 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roycaihw roycaihw roycaihw left review comments

@palnabarun palnabarun palnabarun requested changes

@yliaog yliaog Awaiting requested review from yliaog

Assignees

@roycaihw roycaihw

@palnabarun palnabarun

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@scottilee @roycaihw @k8s-ci-robot @palnabarun