Thanks to visit codestin.com
Credit goes to github.com

Skip to content

updating base for file-like config load support #1253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 9, 2020
Merged

updating base for file-like config load support #1253

merged 2 commits into from
Sep 9, 2020

Conversation

ryphon
Copy link
Contributor

@ryphon ryphon commented Sep 9, 2020

Base PR success, opening PR in main client to support file like config loading.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 9, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @ryphon!

It looks like this is your first PR to kubernetes-client/python 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/python has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 9, 2020
@ryphon
Copy link
Contributor Author

ryphon commented Sep 9, 2020

/retest

@k8s-ci-robot
Copy link
Contributor

@ryphon: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ryphon
Copy link
Contributor Author

ryphon commented Sep 9, 2020

No explanation for port forward test failure. The changes I made would have failed much higher up in the test than this, additionally they would have failed in MANY other places if something was wrong with the python-base code.

@ryphon
Copy link
Contributor Author

ryphon commented Sep 9, 2020

/assign @roycaihw

@yliaog
Copy link
Contributor

yliaog commented Sep 9, 2020

please fix Travis CI build failure

@yliaog
Copy link
Contributor

yliaog commented Sep 9, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 9, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ryphon, yliaog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 9, 2020
@ryphon
Copy link
Contributor Author

ryphon commented Sep 9, 2020

@yliaog Something else is wrong with the portforward_raw test that doesn't involve this PR. The Changelog PR has a failure with this test as well, with the only changes being purely README text.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 9, 2020
@ryphon
Copy link
Contributor Author

ryphon commented Sep 9, 2020

Yeah... @yliaog I'm not sure which commit it was. But that portforward_raw test appears to be inconsistent.

@yliaog
Copy link
Contributor

yliaog commented Sep 9, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 9, 2020
@k8s-ci-robot k8s-ci-robot merged commit 0a78dc1 into kubernetes-client:master Sep 9, 2020
@ryphon ryphon deleted the file-like-base-update branch September 14, 2020 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roycaihw roycaihw Awaiting requested review from roycaihw

@yliaog yliaog Awaiting requested review from yliaog

Assignees

@roycaihw roycaihw

@yliaog yliaog

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ryphon @k8s-ci-robot @yliaog @roycaihw