Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Sync requirements and add license info #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dims
Copy link
Collaborator

@dims dims commented Feb 22, 2017

Follow guidelines in:
https://packaging.python.org/requirements/

  • Make sure the same list of packages are in setup.cfg and
    requirements.txt
  • install_requires reqs in setup.cfg should be "Abstract" with
    no version information
  • Add License information for each package

Fixes #131

Follow guidelines in:
https://packaging.python.org/requirements/

* Make sure the same list of packages are in setup.cfg and
  requirements.txt
* install_requires reqs in setup.cfg should be "Abstract" with
  no version information
* Add License information for each package

Fixes kubernetes-client#131
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 22, 2017
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@6f03708). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #132   +/-   ##
=========================================
  Coverage          ?   94.46%           
=========================================
  Files             ?        9           
  Lines             ?      668           
  Branches          ?        0           
=========================================
  Hits              ?      631           
  Misses            ?       37           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f03708...8ac4254. Read the comment docs.

@mrmcmuffinz
Copy link

@dims Do we have to bump up the release version with these changes?

@dims
Copy link
Collaborator Author

dims commented Feb 22, 2017

@mrmcmuffinz : i'd vote to release another beta to make sure this works fine for folks who want to try it (cc @mbohlool)

@mbohlool
Copy link
Contributor

@dims, this looks good. Can you add an entry in CHANGELOG in the same PR? I want to start requiring that for each PR to make sure we always have updated change log with correct references. I can do another release after this.

@mbohlool
Copy link
Contributor

@dims, I didn't realize the release is broken, I will go ahead and add the changelog myself to do another release.

@mbohlool mbohlool merged commit 2e5d52e into kubernetes-client:master Feb 22, 2017
@mbohlool
Copy link
Contributor

I've released 1.0.0b3. I think we should have an automated check for this to make sure it won't happen in future. Will add an issue for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants