Thanks to visit codestin.com
Credit goes to github.com

Skip to content

examples/pod_exec.py: fix example #1401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 30, 2021
Merged

examples/pod_exec.py: fix example #1401

merged 1 commit into from
Mar 30, 2021

Conversation

Akasurde
Copy link
Contributor

@Akasurde Akasurde commented Mar 23, 2021 •
edited
Loading

Use get_default_copy() API with configuration.

@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 23, 2021
@k8s-ci-robot k8s-ci-robot requested review from roycaihw and yliaog March 23, 2021 04:56
@k8s-ci-robot
Copy link
Contributor

Welcome @Akasurde!

It looks like this is your first PR to kubernetes-client/python 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/python has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 23, 2021
@Akasurde
examples/pod_exec.py: fix example
b3e51c4 
Use get_default_copy() API with configuration.
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Mar 23, 2021
@Akasurde
Copy link
Contributor Author

Fixes: #1396

@Akasurde
Copy link
Contributor Author

/assign @roycaihw

@Akasurde Akasurde mentioned this pull request Mar 23, 2021
Closed
roycaihw
roycaihw reviewed Mar 30, 2021
View reviewed changes
Copy link
Member

@roycaihw roycaihw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

examples/pod_exec.py
c = Configuration()
c.assert_hostname = False
try:
c = Configuration().get_default_copy()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: maybe add a comment that this is the right way of setting the config starting v12.0.0

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 30, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Akasurde, roycaihw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 30, 2021
@k8s-ci-robot k8s-ci-robot merged commit b839eee into kubernetes-client:master Mar 30, 2021
@Akasurde Akasurde deleted the i1396 branch March 30, 2021 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roycaihw roycaihw roycaihw left review comments

@yliaog yliaog Awaiting requested review from yliaog

Assignees

@roycaihw roycaihw

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Akasurde @k8s-ci-robot @roycaihw