Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

mbohlool
Copy link
Contributor

Fixes #140

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 24, 2017
@dims
Copy link
Collaborator

dims commented Feb 24, 2017

LGTM 👍

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@a2b3d5d). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #142   +/-   ##
=========================================
  Coverage          ?   94.46%           
=========================================
  Files             ?        9           
  Lines             ?      668           
  Branches          ?        0           
=========================================
  Hits              ?      631           
  Misses            ?       37           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2b3d5d...fc8a31b. Read the comment docs.

@mbohlool mbohlool added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 24, 2017
@mbohlool mbohlool merged commit db29d8a into kubernetes-client:master Feb 24, 2017
@mrmcmuffinz
Copy link

Do we have to bump up the release version now?

@mbohlool
Copy link
Contributor Author

mbohlool commented Feb 24, 2017

So the plan for stable release is for next Wednesday. I think this change was small and I will wait till Sunday to see if we find anything else. I will do another beta release on Sunday or early Monday to be prepared for Wednesday stable release. Please keep testing :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants