Update README.md with ssl hostname troubleshooting [ci skip] #158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@WilliamDenniss would you please review this? I think we can make error messages more descriptive for both of these troubleshootings, but having them in readme file should be ok for now. |
WilliamDenniss
approved these changes
Mar 15, 2017
README.md
Outdated
| ### Hostname doesn't match | ||
|
|
||
| If you get an ssl.CertificateError complaining about hostname match, your installed packages does not meet version [requirements](requirements.txt). | ||
| Specificly check ipaddress and urllib3 package versions to make sure they met requiurments in [requirements.txt](requirements.txt) file. |
There was a problem hiding this comment.
Typos: requiurments -> requirements. Specificly -> Specifically.
Also, I'd add backquotes to the packages, like ipaddress.
|
Thanks. |
yliaog
pushed a commit
to yliaog/client-python
that referenced
this pull request
Jan 8, 2022
Check is not None in safe_get
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.