removed submodule #1672

yliaog · 2022-01-08T00:22:48Z

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Point directly to the file that the kubernetes/community link was pointing to

…cs-link Remove link to kubernetes-client/community

…token only, no caching)

Attempt to implement exec-plugins support in kubeconfig

fix: read config data with bytes (python3)

…ncode and standard_b64decode.

Replace base64.decodestring for base64.standard_b64decode

*Update unit tests to use ConfigNode() instead of dict()

…onal-values ExecProvider errors when parsing null values

Pep8 has been renamed to pycodestyle

Fix for Travis CI failing on python-base

Refresh GCP tokens on retrieval by overriding client config method.

Fix trailing slash on kube/config failure kubernetes-client#388

Travis CI for Python 3.7

Use yaml.safe_load and yaml.safe_dump

…rncode-idempotent fix: WSClient.returncode not idempotent

…figs that rely on relative paths.

Run kubeconfig exec commands in the correct directory

k8s-ci-robot · 2022-01-08T00:22:51Z

Keywords which can automatically close issues and at(@) or hashtag(#) mentions are not allowed in commit messages.

The list of commits with invalid commit messages:

15474ef fix Run Tests with python 3.5 #88

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

linux-foundation-easycla · 2022-01-08T00:23:18Z

✅ Ben Picolo (529a72a, d54efa7, 4750aa9, b3ddbd9, 72a02cc)
✅ Yu Liao (07ef626, 10ae476, 9d17691)
✅ Aaron Crickenberger (c037d14)
✅ Kubernetes Prow Robot (c9b3113, d68e456, 7d1e449, 2d514ce, 8d7b6f7, 83ebb9d, 4da0fcc, 949c39e, 879ab01, 5c242ea, bd9a852, 260f855, 8497dfb, 2d69e89, f30d840, d2ac885, e077f88, c4de8bd, 5c03b3b, 1d5231c, 474e9fb, 8b748a7, 95858d5, 06c2630, 4f7bcfa, ec31e05, 4b8e89f, 4c1ab55, 5092d96, af42f24, 6ca7a5b, c700068, 9f73cc6, afd1301, 6b65461, 51157aa, a2d1024, 278105e, 7ea5cb4, a25f49e, ff9a5f3, 7e7976b, d30f1e6, b87a5fe, bf5c599, 49ec060, a6a6273, 70d6639, 3ea8003, ded3d12, 7fc2c31, fb86b8a, ab61ca3, 54d188f, 471a678, 3dc7fe0, fd322f7, a5e529d, 2da2b98, fdc9907, 4bf72d7, 6e2e494, 04feb9f, 060cac1, 93aa318, fb425a3, db50d02, e514f69, f38221c, 8a969ee, 4d19204, b4d3aad, d25434b, 0d4f822, 62366ee, 9bf29f7, a0d4a31, 6b0104f, dd15ac6, b0afc93, 0052a68, 5756b94, 21f1d7f, 6023e11, 298f21a, 51460f4, 09dbbe5, 3aa8b4c, a66f8df, b9cc79e, 4f761d3, 06191d3, f0fa950, e7c0c5c)
✅ dovreshef (becae56)
✅ Tomasz Prus (9d78cd7, 328b2d1)
✅ Luiz Eduardo de Christo (260d257)
✅ Phil (3682e9b)
✅ Xianglong Wang (13d5711, be621d3, 2f3247b, 0229f0a, e1f0bed)
✅ Trevor Edwards (8f3a69e)
✅ saberuster (15474ef)
✅ Neha Yadav (86ae2de, d56fdbc, 375befb, 0fc0d40)
✅ Axel Steingrimsson (1637d56)
✅ Julian Taylor (3c30a30)
✅ Roy Lenferink (4d387d5)
✅ Mitar (8e6f043, ad06e5c, 972a76a, 06e48c5)
✅ Oz N Tiram (511243a, c941d74)
✅ Haowei Cai (Roy) (487c918, f2ae80b, ea11e44, 982de11, a7c7829, acdd058, 3f05359, b002110, 96bb22f)
✅ Roger Hoem-Martinsen (30bc425, 26e16d0, 6edea7b)
✅ Fabian von Feilitzsch (7d98f28, 461a3bf, 5b21d65, 53c4cb2, 8ef5857, fb259e1, b0b0dde)
✅ Richard Godden (ca007f3, 4ea6921, 7ce0198)
✅ Sergei Maertens (3827074)
✅ AyliD (34f3d05)
✅ Quentin Lemaire (a29bf29)
✅ Evgenii Ganchurin (6dec044)
✅ Nigel Foucha (0b20833, faf2e0c)
✅ Alexey Volkov (f11587d)
✅ Nabarun Pal (5f395ba, 4e84e7d, a54f404, b68ca30)
✅ Ulrik Mikaelsson (ced17c6, 368d0d7)
✅ Fabrice (39113de, 64662bb)
✅ Shihang Zhang (3cfc41e, 0b1ac80)
✅ Vishnu Prasad S (ab51510, 27a1b81, e92495f, c6e8194, 6c32737, 52a3bdc, 9181235)
✅ Hui.Zhu (3ff79da, 30d9e2a)
✅ Abhijeet Kasurde (a270ea2)
✅ Graham Reed (b85aff2)
✅ Dylan Shepard (f65f06b, aac4e35, f85a41f, bfa9681, 49cbb1d, 9f4775f, 0559445)
✅ Patrick J. McNerthney (fd62214, a00ed7f, 74d0e29, cc9ae10, 72e3725, 7bf04b3, ce3a1a2, 2e86b71, 5d39d0d)
✅ Gábor Lipták (3412151)
✅ Sumant (4d29af1)
✅ Mridul Seth (8a3bdb8, 76d8fbd, 3c71987)
✅ jamesge (18a5ccc, ec1e85e, e09312a, bd944a5)
✅ Chris Ayoub (ebea7e3)
✅ Bob Killen (2ea3efb)
✅ mthaddon (ed98dae)
✅ Darren Hague (9039966)
✅ Onecer (fc5b730)
✅ jonasdlindner (90e16c6)
✅ Yash Singh (bde3935)
✅ Priyanka Saggu (711d4ab)
✅ David (dca0ca6, e2ba3fb)
✅ Andrei Marin (6f9e332)
✅ Mike Graves (cbb7169)
✅ Hedi Nasr (59ba58b)
✅ piglei (66a45cd)
✅ Eric Menendez (70b78cd)
✅ schnee (c040d87)
✅ abikouo (281f17a)
✅ itaru2622 (769bc57, 8777271, 59e7d11, f23b284, 4ef4139)
✅ Dipto Chakrabarty (95e2e85)
✅ WalkerWang731 (8b306c0)
✅ Ping He (bc697ae)
✅ John Sun (18828d9)
✅ Aurélien Gasser (79e066a)
✅ April Schleck (1c5bf58, 6efd33d)

❌ The commit (ebb49d0 ,13ff5184ac43c0bffa813bbba4fca04d610c45d7 ,69570ac7088e78edab2d41809a86be2cd9e6e2fd ,a4f249b48a467e8c605c09a944a14d6eb6e62b9a) is missing the User's ID, preventing the EasyCLA check. Consult GitHub Help to resolve.For further assistance with EasyCLA, please submit a support request ticket.
❌ - Moshe Shitrit The commit (7199c14 ,0c662bb33dfb49236ca4c68b81d426d8948da224 ,10db259908b025cfdcbba28c455de9bac54e16aa ,2c9ddf94b6614c9f16a234de0ce69e01270466c6 ,8e4c5ebe4f1aa9d1889b7c31de1b1fd600db9744 ,9bce8696ffb10e30757e93e72d5c4970d5144c16 ,0395a107185cef66592dfd26dbb8118179d272c4 ,34b8304d5fe0b95df8b9968f766cf9e8598e778a ,0a5b04feead64f73ae042665251e3aef5e35f84e ,cf2f312fd06debceee9a06afe2eefccbd2649f1e ,b5aa2dd3718949a066cf1f01927ef4432f2e4dcc ,698299af9d3229d02624c4e6bb87e076bdcea000 ,6d1c8d3713057e87d973d853b36373c06901d092) is not authorized under a signed CLA. Please click here to be authorized. For further assistance with EasyCLA, please submit a support request ticket.
❌ - aagten The commit (d47030a) is not authorized under a signed CLA. Please click here to be authorized. For further assistance with EasyCLA, please submit a support request ticket.

yliaog · 2022-01-08T00:23:27Z

/release-note-none

yliaog · 2022-01-08T00:24:50Z

/assign @roycaihw

k8s-ci-robot · 2022-01-08T00:27:56Z

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

roycaihw · 2022-01-27T01:56:49Z

Why do we have these many (321) commits?

yliaog · 2022-01-28T00:23:10Z

the commits are old, they are added to preserve the commit history

roycaihw · 2022-01-31T18:31:27Z

/lgtm
/approve

k8s-ci-robot · 2022-01-31T18:31:37Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roycaihw, yliaog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [roycaihw,yliaog]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

leoskyrocker · 2022-04-26T15:09:00Z

@yliaog @roycaihw
it's not easy to see the actual changes here.
The wrapper function is great, thank you for adding it!
I would use it if we're saying we can commit to supporting it, but right now it seems like there is not actual documentation around it (?)

I'm wondering if it is going to be likely for the wrapper function to suddenly disappear/change drastically in the upcoming versions.
Alternatively, we could update the documentation if we think it is here to stay (and stay consistent) for the foreseeable future?

roycaihw · 2022-05-11T16:24:52Z

@leoskyrocker From the slack thread I think you mean the behavior of load_config loading out-of-cluster or in-cluster kubeconfig.

The behavior was inspired by client-go. We don't plan to drop this behavior. It would be nice if we document the behavior. cc @MoShitrit

leoskyrocker · 2022-05-11T16:32:16Z

yep, sorry for the confusion as I couldn't trace back the original PR earlier and thought this PR introduced the load_config function.

Thanks for the update!

bpicolo and others added 30 commits July 30, 2018 15:26

Fix base64 padding for kube config

529a72a

added OWNERS file.

07ef626

Remove link to kubernetes-client/community

c037d14

Point directly to the file that the kubernetes/community link was pointing to

Merge pull request kubernetes-client#83 from spiffxp/update-design-do…

c9b3113

…cs-link Remove link to kubernetes-client/community

Merge branch 'master' into fix_base64_padding_for_kconfig

d54efa7

Add partial support for out-of-tree client authentication providers (…

becae56

…token only, no caching)

Merge pull request kubernetes-client#75 from dovreshef/master

d68e456

Attempt to implement exec-plugins support in kubeconfig

fix: read config data with bytes (python3)

9d78cd7

Merge pull request kubernetes-client#86 from tomplus/fix/config-bytes

7d1e449

fix: read config data with bytes (python3)

Fix Issue-60: Replace encodestring and decodestring for standard_b64e…

260d257

…ncode and standard_b64decode.

Merge pull request kubernetes-client#90 from dechristo/Issue-634

2d514ce

Replace base64.decodestring for base64.standard_b64decode

*Update ExecProvider to use safe_get()

3682e9b

*Update unit tests to use ConfigNode() instead of dict()

Merge pull request kubernetes-client#91 from fillbit/handle-null-opti…

8d7b6f7

…onal-values ExecProvider errors when parsing null values

pep8 to pycodestyle

13d5711

Merge pull request kubernetes-client#95 from micw523/master

83ebb9d

Pep8 has been renamed to pycodestyle

Fix for Travis CI failing on python-base

be621d3

Merge pull request kubernetes-client#99 from micw523/update-ubuntu-ver

4da0fcc

Fix for Travis CI failing on python-base

Refresh GCP tokens on retrieval by overriding client config method.

8f3a69e

Merge pull request kubernetes-client#92 from TrevorEdwards/59_override

949c39e

Refresh GCP tokens on retrieval by overriding client config method.

Travis CI for Python 3.7

2f3247b

Merge pull request kubernetes-client#45 from bran-wang/master

879ab01

Fix trailing slash on kube/config failure kubernetes-client#388

fix kubernetes-client#88

15474ef

Add verify-boilerplate script

86ae2de

Verify Boilerplate fix

d56fdbc

Merge pull request kubernetes-client#100 from micw523/master

5c242ea

Travis CI for Python 3.7

Make dependancy adal optional

375befb

Add email scope to GCP provided credential refresh

1637d56

Use safe_load and safe_dump for all yaml calls

ebb49d0

linting

13ff518

Merge pull request kubernetes-client#111 from xvello/xvello/safe_load

bd9a852

Use yaml.safe_load and yaml.safe_dump

k8s-ci-robot and others added 5 commits December 14, 2021 13:54

Merge pull request kubernetes-client#272 from AurelienGasser/fix-retu…

f0fa950

…rncode-idempotent fix: WSClient.returncode not idempotent

Run kubeconfig exec commands in the correct directory. This fixes con…

1c5bf58

…figs that rely on relative paths.

Add a test to kube_config_test to check the cwd of the ExecProvider

6efd33d

Merge pull request kubernetes-client#275 from aschleck/cwd

e7c0c5c

Run kubeconfig exec commands in the correct directory

removed submodule

9d17691

k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 8, 2022

k8s-ci-robot requested a review from roycaihw January 8, 2022 00:23

k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 8, 2022

k8s-ci-robot assigned roycaihw Jan 8, 2022

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jan 8, 2022

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 31, 2022

roycaihw merged commit 1271465 into kubernetes-client:master Jan 31, 2022

jonasdlindner mentioned this pull request Apr 7, 2022

Adjust CONTRIBUTING.md to new repo structure #1771

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

removed submodule #1672

removed submodule #1672

Uh oh!

yliaog commented Jan 8, 2022

Uh oh!

k8s-ci-robot commented Jan 8, 2022

Uh oh!

linux-foundation-easycla bot commented Jan 8, 2022

Uh oh!

yliaog commented Jan 8, 2022

Uh oh!

yliaog commented Jan 8, 2022

Uh oh!

k8s-ci-robot commented Jan 8, 2022

Uh oh!

roycaihw commented Jan 27, 2022

Uh oh!

yliaog commented Jan 28, 2022

Uh oh!

roycaihw commented Jan 31, 2022

Uh oh!

k8s-ci-robot commented Jan 31, 2022

Uh oh!

leoskyrocker commented Apr 26, 2022 •

edited

Loading

Uh oh!

roycaihw commented May 11, 2022

Uh oh!

leoskyrocker commented May 11, 2022

Uh oh!

Uh oh!

removed submodule #1672

removed submodule #1672

Uh oh!

Conversation

yliaog commented Jan 8, 2022

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Uh oh!

k8s-ci-robot commented Jan 8, 2022

Uh oh!

linux-foundation-easycla bot commented Jan 8, 2022

Uh oh!

yliaog commented Jan 8, 2022

Uh oh!

yliaog commented Jan 8, 2022

Uh oh!

k8s-ci-robot commented Jan 8, 2022

Uh oh!

roycaihw commented Jan 27, 2022

Uh oh!

yliaog commented Jan 28, 2022

Uh oh!

roycaihw commented Jan 31, 2022

Uh oh!

k8s-ci-robot commented Jan 31, 2022

Uh oh!

leoskyrocker commented Apr 26, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

roycaihw commented May 11, 2022

Uh oh!

leoskyrocker commented May 11, 2022

Uh oh!

Uh oh!

leoskyrocker commented Apr 26, 2022 •

edited

Loading