Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Inline primitive models in preprocessing #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 24, 2017
Merged

Inline primitive models in preprocessing #179

merged 4 commits into from
Apr 24, 2017

Conversation

mbohlool
Copy link
Contributor

@mbohlool mbohlool commented Apr 17, 2017 •
edited
Loading

There are at least four models at the time of this PR that are considered to be primitive and code generator does not generate a valid code for them:

intstr.IntOrString
v1.Patch
v1.Time
resource.Quantity

This PR will make these models inline in the preprocessing step. The effect would be at least a working client with APIs related to these models. It makes v1.Patch an object, v1.Time a datetime and resource.Quantity a str. This Will resolve #173 #117 #118, but partially resolve #18 as it marks IntOrString a str. We still need to define a custom type for IntOrString.

Fixes #173, #117, #118

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 17, 2017
@mbohlool mbohlool added this to the V2.0 milestone Apr 17, 2017
@mbohlool mbohlool added kind/feature Categorizes issue or PR as related to a new feature. generated-client-updated interface-changed labels Apr 17, 2017
@codecov-io
Copy link

codecov-io commented Apr 18, 2017 •
edited
Loading

Codecov Report

Merging #179 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #179   +/-   ##
=======================================
  Coverage   94.46%   94.46%           
=======================================
  Files           9        9           
  Lines         668      668           
=======================================
  Hits          631      631           
  Misses         37       37

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e69d4fe...c8374eb. Read the comment docs.

@dims
Copy link
Collaborator

dims commented Apr 24, 2017

/lgtm

@mbohlool mbohlool merged commit f399ece into kubernetes-client:master Apr 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dims dims

@detiber detiber

@sebgoa sebgoa

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. generated-client-updated interface-changed kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
V2.0
Development

Successfully merging this pull request may close these issues.

V1Patch.md is missing int-or-string
6 participants
@mbohlool @codecov-io @dims @detiber @sebgoa @k8s-ci-robot