Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Port Kubernetes cherry-pick script #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 24, 2017
Merged

Port Kubernetes cherry-pick script #186

merged 4 commits into from
Apr 24, 2017

Conversation

mbohlool
Copy link
Contributor

Kubernetes main repo has a cherry pick script that is useful for client-python, now that we have more than one release branch. I've generalized the script a bit and port it for our use.

@mbohlool mbohlool added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 20, 2017
@mbohlool mbohlool self-assigned this Apr 20, 2017
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 20, 2017
@codecov-io
Copy link

codecov-io commented Apr 20, 2017 •
edited
Loading

Codecov Report

Merging #186 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #186   +/-   ##
=======================================
  Coverage   94.56%   94.56%           
=======================================
  Files           9        9           
  Lines         681      681           
=======================================
  Hits          644      644           
  Misses         37       37

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff83fb6...9e738e4. Read the comment docs.

@zmerlynn
Copy link

/lgtm

@zmerlynn
Copy link

Actually .. can you squash and get rid of those weird master commits? I just noticed the commit count.

(You should be rebasing the PR, it looks like you're trying to merge a merge commit here.)

@mbohlool
Copy link
Contributor Author

mbohlool commented Apr 24, 2017 •
edited
Loading

@zmerlynn Those merge commits created by github UI directly. When I merge pull request they should disappear (I think). I will check that before merge.
Thanks for review.

@mbohlool mbohlool merged commit 5e7cdca into kubernetes-client:master Apr 24, 2017
@mbohlool
Copy link
Contributor Author

@zmerlynn I assumed that those merge commit will go away but look like at least one of them stayed when I merged. I should somehow disable UI for that. Thanks for pointing it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mbohlool mbohlool

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mbohlool @codecov-io @zmerlynn @k8s-ci-robot