Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Automated cherry pick of #183 #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

mbohlool
Copy link
Contributor

Cherry pick of #183 on release-1.0.

#183: BUGFIX: token file should not be decoded

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 24, 2017
@codecov-io
Copy link

Codecov Report

Merging #189 into release-1.0 will increase coverage by 0.1%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff               @@
##           release-1.0     #189     +/-   ##
==============================================
+ Coverage        94.46%   94.56%   +0.1%     
==============================================
  Files                9        9             
  Lines              668      681     +13     
==============================================
+ Hits               631      644     +13     
  Misses              37       37
Impacted Files Coverage Δ
kubernetes/config/kube_config.py 96.47% <100%> (+0.1%) ⬆️
kubernetes/config/kube_config_test.py 92.22% <100%> (+0.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3517bed...2c80352. Read the comment docs.

@mbohlool
Copy link
Contributor Author

original PR has LGTM. the diff is exactly the same.

@mbohlool mbohlool merged commit f45238d into kubernetes-client:release-1.0 Apr 24, 2017
@mbohlool
Copy link
Contributor Author

This is a backward incompatible change (people may fixed their token file to make it work). Reverting PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants