Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

pokoli
Copy link

@pokoli pokoli commented Jun 2, 2017

Fixes #136

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 2, 2017
@pokoli
Copy link
Author

pokoli commented Jun 2, 2017

I also added test-requirments as test_requires on setup.py, which will make the test requeriments installed when running python setup.py test for me is the expected behaviour, but let me know if you have some remarks with it.

@mbohlool
Copy link
Contributor

mbohlool commented Jun 4, 2017

Thanks for the PR. It looks good. The new REQUIRES list, however, is a little different after this PR (It has all versions in it as well as commented license). Do we know that is fine? I think there were a guideline somewhere to not include versions in REQUIRES field.

@mbohlool mbohlool self-requested a review June 4, 2017 07:22
@mbohlool mbohlool self-assigned this Jun 4, 2017
@pokoli
Copy link
Author

pokoli commented Jun 5, 2017

@mbohlool for me the important part is that requirements and setup.py must contain the same package dependencies, so installing with requeriments and with setup.py produces the exact same behaviour. Having said that, if you do not want the versions in the setup.py I think we should not include on requirements.txt, but maybe this out of the scope of this PR. (I can create a new one if you prefer).

@mbohlool
Copy link
Contributor

mbohlool commented Jun 5, 2017

More information here: https://packaging.python.org/requirements/

I think we can go ahead with this PR.

@mbohlool mbohlool added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 5, 2017
@mbohlool mbohlool merged commit ff94d26 into kubernetes-client:master Jun 5, 2017
yliaog pushed a commit to yliaog/client-python that referenced this pull request Jan 8, 2022
…gu-drop-python2-support

drop python2 support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants