Add basic submodules documentation #245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pokoli
reviewed
Jun 7, 2017
devel/submodules.md
Outdated
| git submodule update --remote | ||
| ``` | ||
|
|
||
| and commit changes and send a PR for it. |
There was a problem hiding this comment.
I will prefer: "Once updated, you should fill a new PR to upload changes for the repository" or something similar.
What do you think?
There was a problem hiding this comment.
That's what I mean. You should commit your changes to your clone then send a pull request for your changes.
There was a problem hiding this comment.
Yes, but I will prefer to make it clearer on the docs :)
There was a problem hiding this comment.
to me fill and upload doesn't feel right. I prefer create and commit.
How about:
"Once updated, you should create (or send) a new PR to commit changes to the repository".
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using submodules to handle dependencies to base repo and we need a reference docs for steps of updating it.