Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Use py.test instead of nosetests for better problem reporting #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2017
Merged

Use py.test instead of nosetests for better problem reporting #282

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions test-requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
coverage>=4.0.3
nose>=1.3.7
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this anymore?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, testenv:coverage still uses both coverage and nose.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. this looks good, can you rebase your branch so I can merge it? (the branch is out of date).

pytest
pluggy>=0.3.1
py>=1.4.31
randomize>=0.13
Expand Down
8 changes: 4 additions & 4 deletions tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ deps = -r{toxinidir}/test-requirements.txt
-r{toxinidir}/requirements.txt
commands =
python -V
nosetests -e e2e -v
py.test -vvv -s --ignore=kubernetes/e2e_test

[testenv:docs]
commands =
Expand All @@ -22,17 +22,17 @@ commands =
[testenv:py27-functional]
commands =
python -V
{toxinidir}/scripts/kube-init.sh nosetests -v []
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why only these two e2e tests? what about py36-functional and non-e2e tests? can we use py.test for those too?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switched them all except for coverage. Let's wait on that one to see if it runs into trouble

{toxinidir}/scripts/kube-init.sh py.test -vvv -s []

[testenv:py35-functional]
commands =
python -V
{toxinidir}/scripts/kube-init.sh nosetests -v []
{toxinidir}/scripts/kube-init.sh py.test -vvv -s []

[testenv:py36-functional]
commands =
python -V
{toxinidir}/scripts/kube-init.sh nosetests -v []
{toxinidir}/scripts/kube-init.sh py.test -vvv -s []

[testenv:coverage]
commands =
Expand Down